[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHI...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33189 )

Change subject: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHICS_ENABLING
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c 
File src/soc/intel/icelake/graphics.c:

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c@48 
PS1, Line 48: DDI_A_4_LANES
> > Those registers are applicable for ICL as well. […]

I don't have doubt that you could be an expert but i'm telling you something that i'm living with. We just like that can't remove that code, its been added for an purpose and that purpose is still valid as i could see.

I guess i have provided enough justification why this code is needed and given my experiment details as well.

I don't know what else i can provide you. Request you to not block code development else we would be able to land early soc code into cb.