Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45059/2/src/lib/bootblock.c File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/2/src/lib/bootblock.c@28 PS2, Line 28: void bootblock_main_with_timestamp(uint64_t base_timestamp,
Okay, I'll split patches.
Done
https://review.coreboot.org/c/coreboot/+/45059/2/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/2/src/soc/amd/picasso/bootblo... PS2, Line 125: CONFIG_PSP_SHAREDMEM_BASE;
You should cast ints through uintptr_t for establishing pointer values.
Are you referring to line 132? Or did you mean "(struct transfer_info_struct *)(uintptr_t)CONFIG_PSP_SHAREDMEM_BASE"?