Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36145 )
Change subject: arch/arm: Pass cbmem_top to ramstage via calling argument
......................................................................
Patch Set 18: Code-Review+2
(1 comment)
Did we abandon the idea of passing through to main() now? I'd consider this is okay as is, but I still think passing through to main() would be a bit cleaner.
https://review.coreboot.org/c/coreboot/+/36145/18/src/arch/arm/stages.c
File src/arch/arm/stages.c:
https://review.coreboot.org/c/coreboot/+/36145/18/src/arch/arm/stages.c@32
PS18, Line 32: void
nit: If you want this as a uintptr_t, just make it a uintptr_t.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If31f0f1de17ffc92c9397f32b26db25aff4b7cab
Gerrit-Change-Number: 36145
Gerrit-PatchSet: 18
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 30 Oct 2019 00:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment