Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51683 )
Change subject: soc/intel/alderlake: Add provision to override DDR config
......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/51683/comment/396fae0e_f1322ffa
PS4, Line 17: override_ddr_config
Maybe `set_rcomp_config`?
Ack
https://review.coreboot.org/c/coreboot/+/51683/comment/e432920d_348250db
PS4, Line 233: override_ddr_config(mem_cfg, &mb_cfg->ddr_config);
Do we need the `OVERRIDE_DDR_CONFIG` Kconfig symbol, though? […]
Ack
https://review.coreboot.org/c/coreboot/+/51683/comment/31d21287_b71d5a0d
PS4, Line 238: mb_cfg->ddr_config
`mb_cfg->ddr_config` is aliased with `mb_cfg->lp5x_config`, so this will not work. […]
Thanks Angel, i will leave LP5 as is for now and do the further clean up as you have suggested later.
Is that good ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8528bbf0517728534d47f9adaabfc9a2c469609
Gerrit-Change-Number: 51683
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 15:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment