Attention is currently required from: Jérémy Compostella.
Zhixing Ma has posted comments on this change by Zhixing Ma. ( https://review.coreboot.org/c/coreboot/+/85960?usp=email )
Change subject: mainboard/google/fatcat: Fix SMBIOS Processor upgrade info ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85960/comment/183d6c70_51fde446?usp... : PS7, Line 9: The current SMBIOS for fatcat is missing processor upgrade info,
information […]
Done
https://review.coreboot.org/c/coreboot/+/85960/comment/f7c405c1_0b231f0e?usp... : PS7, Line 10: This patch adds the missing value by enabling a kconfig flag.
which Kconfig flag ?
Done
https://review.coreboot.org/c/coreboot/+/85960/comment/b566cb35_06460ae4?usp... : PS7, Line 12: https://web.archive.org/web/20221012222420/https://www.dmtf.org/sites/defaul...
can't you give the direct link https://www.dmtf. […]
This was requested by coreboot maintainers on similar patch prior.
https://review.coreboot.org/c/coreboot/+/85960/comment/7df0c9ed_26983d2b?usp... : PS7, Line 15: TEST=Boot and verified that SMBIOS processor upgrade value is correct.
I would keep the BUG and TEST tags at the end of the commit message.
Done
https://review.coreboot.org/c/coreboot/+/85960/comment/210013db_90cf9460?usp... : PS7, Line 18: Processor Information
I would personally prefer a diff representation like […]
Done