Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48701 )
Change subject: ACPI: Drop redundant CBMEM_ID_ACPI_GNVS allocations
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48701/8/src/acpi/Kconfig
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/48701/8/src/acpi/Kconfig@27
PS8, Line 27: ACPI_SOC_NVS
So this is for platforms that have the definition of 'struct global_nvs' in <soc/nvs. […]
That, and a <soc/nvs.h> in the include paths in the first place.
The longterm plan was to move every sb/intel/xxx/nvs.h to match <soc/nvs.h> and have the Kconfig removed.
https://review.coreboot.org/c/coreboot/+/48701/8/src/soc/intel/quark/include...
File src/soc/intel/quark/include/soc/nvs.h:
PS8:
Is it easy to keep Quark without GNVS?
Well.. we could move "select ACPI_SOC_NVS" to each soc/intel/*/KConfig separately instead of having it in intel/common/ only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48701
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b2625af15cae90b9c1eb601e606d0430336609f
Gerrit-Change-Number: 48701
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 18:05:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment