Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37935 )
Change subject: src/mainboard/*.asl: Remove _HID / _ADR objects
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37935/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37935/7//COMMIT_MSG@9
PS7, Line 9: A device object must contain either a _HID object or an _ADR object,
: but should not contain both.
one of them is wrong. […]
I understand this change is to be ACPI 6.3 spec compliant (though that should probably be in the commit msg, not just the comments here), just looking for an explanation as to why the _HID was removed in the case of the Aopen board, vs the _ADR
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I949393558f5af66689c167b2e593a1461f641962
Gerrit-Change-Number: 37935
Gerrit-PatchSet: 7
Gerrit-Owner: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jan 2020 18:08:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment