Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )
Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu...
PS2, Line 216: ACPI_IRQ_EDGE_LOW
Thanks for the info, Furquan. Learn from you.
change to LEVEL-triggered
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia361a56c050d7cbd7325b3c09fc34d8707441cc4
Gerrit-Change-Number: 46808
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 05:22:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment