Attention is currently required from: Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74557 )
Change subject: soc/qualcomm/sc7180: Fix set but unused variables ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74557/comment/b2f1f635_2dab4230 PS5, Line 9: This fixes clang warnings. I'm not against fixing these warnings, but why is that a GCC vs. clang difference? GCC also has -Wunused-but-set-variable (at least according to https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html). If there's a difference in defaults between the two, we should eliminate that by explicitly adding -Wno-unused-but-set-variable (or rather add -Wunused-but-set-variable after fixing all these so GCC can check it as well).
File src/soc/qualcomm/sc7180/display/disp.c:
https://review.coreboot.org/c/coreboot/+/74557/comment/929b9699_5cb57339 PS5, Line 11: /* Is this necessary ? */ No, it's not (I just tested it). Let's take it out completely.