Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31371 )
Change subject: soc/intel/apl: enable lpc at bootblock ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/31371/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/31371/7//COMMIT_MSG@9 PS7, Line 9: Serial console can be attached to lpc bus. Enable it for early debug Please add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/31371/7/src/soc/intel/apollolake/lp... File src/soc/intel/apollolake/lpc.c:
https://review.coreboot.org/c/coreboot/+/31371/7/src/soc/intel/apollolake/lp... PS7, Line 50: 0x00 0x0?