Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33454 )
Change subject: sb/amd/cimx/sb900: Change logical negation to bitwise
......................................................................
Patch Set 1: Code-Review+2
I would suggest to wipeout agesa/fam12 and cimx/sb900 after 4.10 release. We are just dragging these along for amd/torpedo, a CRB that only Martin might still have.
I concur. I was never aware of any AMD customers using Family 12h. IIRC it was never an Embedded offering.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33454
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2179119e0d2d4aceaf4f8b499bf4c5baf4ef677f
Gerrit-Change-Number: 33454
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:07:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment