Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32271 )
Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... File src/mainboard/google/mistral/boardid.c:
https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... PS10, Line 41: if (bid == 0)
that open brace { should be on the previous line
Done
https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... PS10, Line 43: if (is_tpm_detected() == 0) {
braces {} are not necessary for single statement blocks
yuck.