Attention is currently required from: Arthur Heymans, Christian Walter, Eric Lai, Jakub Czapiga, Jeff Daly, Johnny Lin, Sean Rhodes, Tim Chu, Vanessa Eusebio.
Marek Maślanka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80005?usp=email )
Change subject: soc/intel: Unify the definition of TCO registers
......................................................................
Patch Set 10:
(1 comment)
File src/southbridge/intel/common/tco.h:
https://review.coreboot.org/c/coreboot/+/80005/comment/8950804e_0d5e03ea :
PS9, Line 15: #define PMBASE_TCO_OFFSET 0x60
Can not be common?
Yes, it's common, but intention of this CL is to unify TCO registers and fields themselves. PMBASE_TCO_OFFSET can be move to pmbase.h in separate CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80005?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id64a635d106cea879ab08aa7beca101de14b1ee6
Gerrit-Change-Number: 80005
Gerrit-PatchSet: 10
Gerrit-Owner: Marek Maślanka
mmaslanka@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 29 Jan 2024 09:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment