Attention is currently required from: Michał Żygowski, Subrata Banik, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63459 )
Change subject: soc/intel/alderlake/include/soc/iomap.h: Add ADL PCH-S reserved spaces
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/63459/comment/52eb6d8d_0f9bdf28
PS3, Line 16: PCH_PRESERVED_BASE_ADDRESS
Should we convert these to Kconfigs to avoid #ifdefs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifefedc629def207ecd6f7be792f6e12fb6016cc3
Gerrit-Change-Number: 63459
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 16:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment