Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44930 )
Change subject: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX'
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG@7
PS1, Line 7: redundant
It is not redundant. TXT *requires* VMX to be enabled. […]
I agree. Another way to see it: ENABLE_VMX has a prompt and is
user-configurable. And the `select` here makes sure the user
can't break things.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4582d86b08c68436d7f792194c9c5124885dd45
Gerrit-Change-Number: 44930
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 18:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment