Attention is currently required from: Maulik V Vaghela, Reka Norman, Rizwan Qureshi. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63237 )
Change subject: soc/intel/common/tcss: Check conn device enabled in tcss_get_port_info ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2: While looking at this again, since we already have a required hardcoded device path to each CONN device (pmc -> pmc_mux -> conn0, conn1, etc.), would it make sense to have this information be explicit in the chipset.cb file for ADL? Then an array of `const struct device *` to these devices could be passed into tcss_configure() instead ?
e.g.
adl/chipset.cb ``` device pci 1f.2 alias pmc hidden chip drivers/intel/pmc_mux device generic 0 on chip drivers/intel/pmc_mux/conn device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn device generic 1 alias conn1 on end end chip drivers/intel/pmc_mux/conn device generic 2 alias conn2 on end end chip drivers/intel/pmc_mux/conn device generic 3 alias conn3 on end end
end end end ```
then adl fsp_params.c just uses DEV_PTR() for each of these to get an array and passes that into tcss_configure() instead?