Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32466 )
Change subject: google/kukui: Raising the CPU frequency
......................................................................
Patch Set 3:
Thanks for the great info. Can state that in comment before we call the function to raise CPU freq?
So that if someone is trying to optimize they won't miss it.
I add comment in mt6358_init().
The idea is that we don't have to worry about anything if mt6358_init() return after voltage became stable.
I know it's not good to modify files of soc and mainboard in the same patch.
But, can we do that for this case?
Since we only add comments in mt6358.c and they are both for the same issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I703ffcb99367f87e6792a72485f5634e0505e5ac
Gerrit-Change-Number: 32466
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Fri, 26 Apr 2019 11:09:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment