Vladimir Serbinenko (phcoder@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7568
-gerrit
commit e44bbd2f64a27f1e7555e9ddcfec3858fbafa27d Author: Vladimir Serbinenko phcoder@gmail.com Date: Sat Nov 22 21:12:14 2014 +0100
i945: Disable check for 2-dimm support.
The check is wrong. On Acer Aspire One it returns 0 despite 2 DIMMs working fine on the same channel if this check is disabled (tested by memtest). On boards that have only 1 DIMM per channel, the code will simply find no SPD and skip empty slot.
Change-Id: I5f2fdcd1d948ebf3eabebaea4441af4c19e47f8f Signed-off-by: Vladimir Serbinenko phcoder@gmail.com --- src/northbridge/intel/i945/raminit.c | 14 -------------- 1 file changed, 14 deletions(-)
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index c3f9bae..4011287 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -211,16 +211,6 @@ static int sdram_capabilities_enhanced_addressing_xor(void) return (!reg8); }
-static int sdram_capabilities_two_dimms_per_channel(void) -{ - u8 reg8; - - reg8 = pci_read_config8(PCI_DEV(0, 0x00, 0), 0xe8); /* CAPID0 + 8 */ - reg8 &= (1 << 0); - - return (reg8 != 0); -} - // TODO check if we ever need this function #if 0 static int sdram_capabilities_MEM4G_disable(void) @@ -383,10 +373,6 @@ static void sdram_get_dram_configuration(struct sys_info *sysinfo) if (!sdram_capabilities_dual_channel() && (i >> 1)) continue;
- /* Two DIMMs per channel not supported, but odd DIMM number? */ - if (!sdram_capabilities_two_dimms_per_channel() && (i& 1)) - continue; - printk(BIOS_DEBUG, "DDR II Channel %d Socket %d: ", (i >> 1), (i & 1));
if (spd_read_byte(device, SPD_MEMORY_TYPE) != SPD_MEMORY_TYPE_SDRAM_DDR2) {