Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55437 )
Change subject: ec/google: Fix bad return value ......................................................................
ec/google: Fix bad return value
google_chromeec_get_event should return 0 on error. Returning 1 on error will cause an infinite loop.
BUG=b:184074997 TEST=Boot guybrush, no ec errors
Change-Id: I6c0186e4637af9ae24f45cce3638f0913227d6a7 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/55437/1
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 3b2a746..623aed5 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -465,7 +465,7 @@ { if (google_chromeec_wait_ready(EC_LPC_ADDR_ACPI_CMD)) { printk(BIOS_ERR, "Timeout waiting for EC ready!\n"); - return 1; + return 0; }
/* Issue the ACPI query-event command */