Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44582 )
Change subject: tint: introduce the new tint build system with checksum verification ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
Thank you for working on this. For me this solution looks very much overengineered, or I do not understand it.
Would it be possible to do this without shell scripts and mostly in the Makefile?
Although I could've copied the useful functions of buildgcc into a simple Makefile, I wanted them to always be the latest version - without tracking the updates of buildgcc script, as I don't have time for that. So made this "extractor". Yes, a bit over-engineered, but solves a real problem ;-)
https://review.coreboot.org/c/coreboot/+/44582/1/payloads/external/tint/Make... File payloads/external/tint/Makefile:
https://review.coreboot.org/c/coreboot/+/44582/1/payloads/external/tint/Make... PS1, Line 14: TINT_CHECKSUM="7fcaa428c6d0de7096d1e4fbfd14848096ae5aad"
Please add the hash type to the variable name: TINT_MD5SUM or TINT_SHA….
Thank you, on my TODO list (need to make sure that nothing will break).