Attention is currently required from: Zheng Bao. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/58842
to review the following change.
Change subject: amd/hda: Remove the weak function ......................................................................
amd/hda: Remove the weak function
BUG=b:140165023
Change-Id: I4b089b9fe4742b29686198f20fc7c1a2dae6f015 Signed-off-by: Zheng Bao fishbaozi@gmail.com
temp.
Change-Id: Idd2ba8ebf18964e5db1a98fb080116d13ac1e407 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/hda/hda.c M src/soc/amd/picasso/Makefile.inc A src/soc/amd/picasso/hda.c 3 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/58842/1
diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c index 104bb9b..5319fc0 100644 --- a/src/soc/amd/common/block/hda/hda.c +++ b/src/soc/amd/common/block/hda/hda.c @@ -20,10 +20,6 @@ return "AZHD"; }
-__weak void hda_soc_ssdt_quirks(const struct device *dev) -{ -} - static void hda_fill_ssdt(const struct device *dev) { acpi_device_write_pci_dev(dev); diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 45e9c80..64bb2f2b 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -46,6 +46,7 @@ ramstage-y += soc_util.c ramstage-y += uart.c ramstage-y += xhci.c +ramstage-y += hda.c
smm-y += smihandler.c ifeq ($(CONFIG_DEBUG_SMI),y) diff --git a/src/soc/amd/picasso/hda.c b/src/soc/amd/picasso/hda.c new file mode 100644 index 0000000..24cba1d7 --- /dev/null +++ b/src/soc/amd/picasso/hda.c @@ -0,0 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +void hda_soc_ssdt_quirks(const struct device *dev) +{ +}