Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47786 )
Change subject: soc/mediatek/mt8192: Init SSPM ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47786/17/src/soc/mediatek/mt8192/so... File src/soc/mediatek/mt8192/soc.c:
https://review.coreboot.org/c/coreboot/+/47786/17/src/soc/mediatek/mt8192/so... PS17, Line 19: sspm_init();
Discussed with CK, they should be all related to SOC initialization flow. […]
you can do that as a follow up.