Pavlushka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 66:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 20: ACTIVE_AC
Um, Sumeet was referring to all the `DPTF_CPU_ACTIVE_ACx` lines, not just the first one... […]
Done
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 204: register "PcieRpClkReqNumber[7]" = "0"
Ack
Done
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 34: // CPU
Ack
Done
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 50: // Chipset specific sleep states
Ack
Done
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 27: 0x0
Done
Done
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 52: 0x2
Done
Done
https://review.coreboot.org/c/coreboot/+/34603/64/src/mainboard/asus/h110m-e... PS64, Line 55: 0x2
Done
Done