John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42187 )
Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec ......................................................................
mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
After adjustment on waddledoo Touch Pad CLK: 392.9 KHz Touch Screen CLK: 387.4 KHz Audio CLK: 350.9 KHz
BUG=b:151302522 BRANCH=master TEST=emerge-dedede coreboot chromeos-bootimage measure by scope with waddledoo.
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Iec02a751f1effdbefbb2969db2fd57f27ecdd033 --- M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/42187/1
diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index 4546c9f..b8be926 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -24,8 +24,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 66, - .fall_time_ns = 90, + .rise_time_ns = 270, + .fall_time_ns = 270, .data_hold_time_ns = 350, }, .i2c[1] = { @@ -33,6 +33,8 @@ }, .i2c[2] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 200, + .fall_time_ns = 200, }, .i2c[3] = { .speed = I2C_SPEED_FAST, @@ -41,8 +43,8 @@ .speed = I2C_SPEED_FAST, .speed_config[0] = { .speed = I2C_SPEED_FAST, - .scl_lcnt = 176, - .scl_hcnt = 95, + .scl_lcnt = 200, + .scl_hcnt = 120, .sda_hold = 36, } },