Attention is currently required from: Lance Zhao, Raul Rangel, Patrick Georgi, Martin Roth, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 )
Change subject: acpi,Makefile: Add preload_acpi_dsdt ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
it seems slightly odd to have a function for each file in CBFS you want to preload. […]
Well, what you have right now seems really fragile, if just shifting a few calls around here and there can completely regress your performance. It would be nice to have something more robust that platforms can just turn on without having to manually fine-tune everything. I think Patrick's write buffer is a good idea. Would have to expand the CBFS prefetch thread a bit to become a full boot device worker thread. Of course this adds more complexity but so did the whole prefetching thing to begin with (and that's why we should also make sure that all of this stays optional and can be fully disabled without leaving any overhead behind).
(As for error handling, there are only so many useful ways you can deal with a SPI write error... ignore, die(), reboot, go into recovery... that's it, probably. Could just have the caller store that preference as an enum value in the write buffer entry.)