Attention is currently required from: Eric Lai, Tongtong Pan.
Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/84196?usp=email )
Change subject: mb/google/dedede/var/awasuki: Update touchscreen power sequence
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84196/comment/dae02c56_4d675e9b?us… :
PS3, Line 9: Reduce resume time.
Have you confirmed that the touchscreen works even after multiple iterations of suspend/resume.
I hope there are no issues with the updated power sequence.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84196?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32b2b1c709ecab964a0e449d416c5d0ee2c1d97d
Gerrit-Change-Number: 84196
Gerrit-PatchSet: 3
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 Sep 2024 13:31:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Felix Singer, Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
Patch Set 19: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 05 Sep 2024 13:20:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83627?usp=email )
Change subject: mb/starlabs/starbook/rpl: Set I2C0 speed to fast
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/83627?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fdbd3124fca27fcd4dced81d8e2aa2f91fe4651
Gerrit-Change-Number: 83627
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Tongtong Pan.
Weimin Wu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/84196?usp=email )
Change subject: mb/google/dedede/var/awasuki: Update touchscreen power sequence
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84196?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32b2b1c709ecab964a0e449d416c5d0ee2c1d97d
Gerrit-Change-Number: 84196
Gerrit-PatchSet: 3
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 05 Sep 2024 12:47:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth, Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84197?usp=email )
Change subject: drivers/i2c/generic: Remove erroneous acpigen_pop_len
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84197?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b
Gerrit-Change-Number: 84197
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Sep 2024 12:19:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Felix Singer, Matt DeVillier, Sean Rhodes.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80705?usp=email
to look at the new patch set (#17).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/byte-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/byte_adl.md
A src/mainboard/starlabs/byte_adl/Kconfig
A src/mainboard/starlabs/byte_adl/Kconfig.name
A src/mainboard/starlabs/byte_adl/Makefile.mk
A src/mainboard/starlabs/byte_adl/acpi/cnvi.asl
A src/mainboard/starlabs/byte_adl/acpi/ec.asl
A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl
A src/mainboard/starlabs/byte_adl/acpi/sleep.asl
A src/mainboard/starlabs/byte_adl/acpi/superio.asl
A src/mainboard/starlabs/byte_adl/board_info.txt
A src/mainboard/starlabs/byte_adl/bootblock.c
A src/mainboard/starlabs/byte_adl/cmos.default
A src/mainboard/starlabs/byte_adl/cmos.layout
A src/mainboard/starlabs/byte_adl/dsdt.asl
A src/mainboard/starlabs/byte_adl/hda_verb.c
A src/mainboard/starlabs/byte_adl/include/variants.h
A src/mainboard/starlabs/byte_adl/mainboard.c
A src/mainboard/starlabs/byte_adl/smbios.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk
A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd
A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd
A src/mainboard/starlabs/byte_adl/vboot.c
29 files changed, 1,550 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 17
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84223?usp=email )
Change subject: soc/intel/alderlake: Migrate Alder Lake to Raptor Lake FSP
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/84223?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I245e35487112559462e057fdae38e535a1008afe
Gerrit-Change-Number: 84223
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 05 Sep 2024 11:15:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No