Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82012?usp=email )
Change subject: vc/amd/opensil/stub/ramstage: add acpi_add_opensil_tables stub
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82012?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ccd2e81211417ad4ac94f208572e0fa4e1cf97c
Gerrit-Change-Number: 82012
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 16:12:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81938?usp=email )
Change subject: soc/intel/alderlake: Enable Early CrashLog support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This sometimes causes reboots for the second expiration of the TCO watchdog.
The next patchset will postpone dumping the CrashLog until after tco_configure(), which calls tco_timer_disable().
--
To view, visit https://review.coreboot.org/c/coreboot/+/81938?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ce47531a74486bc5c996f7793af7087bc30d1f7
Gerrit-Change-Number: 81938
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 22 Apr 2024 16:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS2:
> > > The big difference is binary compatibility. Of course you can start with
> > > something and then maintain the code. But if we want to start with binary
> > > compatibility and maintain binary compatibility (e.g. your very first 2024
> > > payload binary stays compatible with any new coreboot build), then we need
> > > to start with something strictly defined (or it could get rather messy).
> > >
> > > I've put my thoughts into an email[1]. The gist of it is that I don't
> > > see any disadvantage in trunking, rather advantages. Please share your
> > > thoughts, especially, why the trunking should be avoided.
> > >
> > > [1] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/AVDV…
> >
> > Thank you for your response and the valuable discussion.
> >
> > I'd like to clarify that we don't need to introduce a new standard for x86_64 support in libpayload/payload. We're already following the System V AMD64 ABI, which is the standard convention on most Unix-like systems. For adding 64-bit flow we need to ensure that existing 32-bit model is also backward compatible.
> >
> > Here's my proposed outline for the next steps:
> >
> > - Feature/Functional Verification: Thoroughly test the transition from pure 32-bit mode to pure 64-bit mode, ensuring all functionality is preserved.
> >
> > - Mixed Mode Compatibility: Investigate whether we can support scenarios like booting a 32-bit payload with a 64-bit coreboot, or vice versa.
> >
> > - Code Review and Refinement: I greatly appreciate Arthur and Patrick R's initial review and streamlining efforts. Further review will help identify areas for optimization and potential issues.
> >
> > During my work, I didn't encounter a 64-bit exception hence, ignore that it's incomplete. This hasn't caused problems in my testing so far, but it's a critical area to address.
> >
> > - Completing the 64-bit Boot Flow: If you're interested in contributing, please consider helping with the code review (#3) or implementing the missing feature (exception handling functionality etc.). This will ensure our 64-bit boot flow is as robust as the 32-bit one.
>
> > Please share your thoughts, especially, why the trunking should be avoided.
>
> As per Intel next generation platform guideline, the 32-bit boot is considered legacy and wish to ensure the boot flow follows 64-bit mode completely.
>
> We have seen cases where the below 4GB memory might be exhausted with more SoC IP req and we need to use 64-bit mode of entry.
>
> If we like to keep trunking it might solve the problem for short term but we really need to have pure-64 support to work on Intel next gen device (starting with PTL). We have blocked entire PTL upstream until we finish 64-bit mode using upstream coreboot/payload.
>
> I hope it clarifies the doubt.
Additionally, depthcharge the payload for CrOS has compatibility dependency w/ libpayload meaning, we can't build 64-bit depthcharge.elf w/o 32-bit libpayload image hence, we need to ensure both are getting compiled using same toolchain.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Appukuttan V K, Chen, Gang C, Jincheng Li, Jérémy Compostella, Martin L Roth, Ronak Kanabar, Shuo Liu.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80323?usp=email )
Change subject: drivers/intel/fsp2_0: Default to 64-bits for FSP 2.4
......................................................................
Patch Set 33: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80323?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec98
Gerrit-Change-Number: 80323
Gerrit-PatchSet: 33
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:57:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82040?usp=email )
Change subject: libpayload: Save EAX and EBX for multiboot payloads
......................................................................
libpayload: Save EAX and EBX for multiboot payloads
When CONFIG_LP_MULTIBOOT is enabled, save the values of EAX and EBX
passed from the bootloader. This information can be useful for
multiboot payloads feature alone.
Change-Id: I98c2cd00206ee48eb0fc67edd9533032bcf3e5eb
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/arch/x86/head.S
M payloads/libpayload/arch/x86/main.c
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/82040/1
diff --git a/payloads/libpayload/arch/x86/head.S b/payloads/libpayload/arch/x86/head.S
index 1e0e4a0..2bac700 100644
--- a/payloads/libpayload/arch/x86/head.S
+++ b/payloads/libpayload/arch/x86/head.S
@@ -63,9 +63,11 @@
/* No interrupts, please. */
cli
+#if CONFIG(LP_MULTIBOOT)
/* Store EAX and EBX */
movl %eax, loader_eax
movl %ebx, loader_ebx
+#endif
/* save pointer to coreboot tables */
movl 4(%esp), %eax
diff --git a/payloads/libpayload/arch/x86/main.c b/payloads/libpayload/arch/x86/main.c
index 288f474..85636a4 100644
--- a/payloads/libpayload/arch/x86/main.c
+++ b/payloads/libpayload/arch/x86/main.c
@@ -30,8 +30,10 @@
#include <libpayload.h>
#include <arch/apic.h>
+#if CONFIG(LP_MULTIBOOT)
unsigned long loader_eax; /**< The value of EAX passed from the loader */
unsigned long loader_ebx; /**< The value of EBX passed from the loader */
+#endif
int main_argc; /**< The argc value to pass to main() */
--
To view, visit https://review.coreboot.org/c/coreboot/+/82040?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98c2cd00206ee48eb0fc67edd9533032bcf3e5eb
Gerrit-Change-Number: 82040
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Kapil Porwal.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#23).
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
M payloads/libpayload/arch/x86/head.S
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
A payloads/libpayload/arch/x86/libpayload_64.ldscript
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/timer/Kconfig
M payloads/libpayload/drivers/usb/Kconfig
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/include/x86/arch/exception.h
M payloads/libpayload/libc/exec.c
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Kconfig
M payloads/libpayload/vboot/Makefile.mk
28 files changed, 705 insertions(+), 140 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/23
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 23
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS2:
> > The big difference is binary compatibility. Of course you can start with
> > something and then maintain the code. But if we want to start with binary
> > compatibility and maintain binary compatibility (e.g. your very first 2024
> > payload binary stays compatible with any new coreboot build), then we need
> > to start with something strictly defined (or it could get rather messy).
> >
> > I've put my thoughts into an email[1]. The gist of it is that I don't
> > see any disadvantage in trunking, rather advantages. Please share your
> > thoughts, especially, why the trunking should be avoided.
> >
> > [1] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/AVDV…
>
> Thank you for your response and the valuable discussion.
>
> I'd like to clarify that we don't need to introduce a new standard for x86_64 support in libpayload/payload. We're already following the System V AMD64 ABI, which is the standard convention on most Unix-like systems. For adding 64-bit flow we need to ensure that existing 32-bit model is also backward compatible.
>
> Here's my proposed outline for the next steps:
>
> - Feature/Functional Verification: Thoroughly test the transition from pure 32-bit mode to pure 64-bit mode, ensuring all functionality is preserved.
>
> - Mixed Mode Compatibility: Investigate whether we can support scenarios like booting a 32-bit payload with a 64-bit coreboot, or vice versa.
>
> - Code Review and Refinement: I greatly appreciate Arthur and Patrick R's initial review and streamlining efforts. Further review will help identify areas for optimization and potential issues.
>
> During my work, I didn't encounter a 64-bit exception hence, ignore that it's incomplete. This hasn't caused problems in my testing so far, but it's a critical area to address.
>
> - Completing the 64-bit Boot Flow: If you're interested in contributing, please consider helping with the code review (#3) or implementing the missing feature (exception handling functionality etc.). This will ensure our 64-bit boot flow is as robust as the 32-bit one.
> Please share your thoughts, especially, why the trunking should be avoided.
As per Intel next generation platform guideline, the 32-bit boot is considered legacy and wish to ensure the boot flow follows 64-bit mode completely.
We have seen cases where the below 4GB memory might be exhausted with more SoC IP req and we need to use 64-bit mode of entry.
If we like to keep trunking it might solve the problem for short term but we really need to have pure-64 support to work on Intel next gen device (starting with PTL). We have blocked entire PTL upstream until we finish 64-bit mode using upstream coreboot/payload.
I hope it clarifies the doubt.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS2:
> The big difference is binary compatibility. Of course you can start with
> something and then maintain the code. But if we want to start with binary
> compatibility and maintain binary compatibility (e.g. your very first 2024
> payload binary stays compatible with any new coreboot build), then we need
> to start with something strictly defined (or it could get rather messy).
>
> I've put my thoughts into an email[1]. The gist of it is that I don't
> see any disadvantage in trunking, rather advantages. Please share your
> thoughts, especially, why the trunking should be avoided.
>
> [1] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/AVDV…
Thank you for your response and the valuable discussion.
I'd like to clarify that we don't need to introduce a new standard for x86_64 support in libpayload/payload. We're already following the System V AMD64 ABI, which is the standard convention on most Unix-like systems. For adding 64-bit flow we need to ensure that existing 32-bit model is also backward compatible.
Here's my proposed outline for the next steps:
- Feature/Functional Verification: Thoroughly test the transition from pure 32-bit mode to pure 64-bit mode, ensuring all functionality is preserved.
- Mixed Mode Compatibility: Investigate whether we can support scenarios like booting a 32-bit payload with a 64-bit coreboot, or vice versa.
- Code Review and Refinement: I greatly appreciate Arthur and Patrick R's initial review and streamlining efforts. Further review will help identify areas for optimization and potential issues.
During my work, I didn't encounter a 64-bit exception hence, ignore that it's incomplete. This hasn't caused problems in my testing so far, but it's a critical area to address.
- Completing the 64-bit Boot Flow: If you're interested in contributing, please consider helping with the code review (#3) or implementing the missing feature (exception handling functionality etc.). This will ensure our 64-bit boot flow is as robust as the 32-bit one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:46:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72418?usp=email )
Change subject: drivers/intel/gma: Dump output setting only if DEBUG_ADA_CODE is set
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Why was this changed? We don't hide the output of other components in coreboot […]
agreed, not in favor of this change at all. would support a revert.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72418?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadd6c9552b184f7d6ec8df9d0d392634864ba50c
Gerrit-Change-Number: 72418
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Zhixing Ma <zhixing.ma(a)intel.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment