coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3292 discussions

[XS] Change in coreboot[main]: ec/google/chromeec: Update ec_cmd_api.h and ec_commands.h
by Pavan Holla (Code Review) 18 Apr '24

18 Apr '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81965?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ec/google/chromeec: Update ec_cmd_api.h and ec_commands.h ...................................................................... ec/google/chromeec: Update ec_cmd_api.h and ec_commands.h Generated using update_ec_headers.sh [EC-DIR]. The original include/ec_commands.h version in the EC repo is: b3b35d6433 PPM: Rename ucsi_disabled to ucsi_enabled The original include/ec_cmd_api.h version in the EC repo is: 562316a71e include: Add fingerprint host commands to ec_cmd_api.h BUG=b:333078787 TEST=cros build-packages --board brox \ chromeos-bootimage depthcharge coreboot TEST=cros build-packages --board brya \ chromeos-bootimage depthcharge coreboot BRANCH=none Change-Id: I94b509cd6ad8f24bfc3b44ef02633d06320f1e22 Signed-off-by: Pavan Holla <pholla(a)google.com> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/81965/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81965?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94b509cd6ad8f24bfc3b44ef02633d06320f1e22 Gerrit-Change-Number: 81965 Gerrit-PatchSet: 3 Gerrit-Owner: Pavan Holla <pholla(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Caveh Jalali <caveh(a)chromium.org> Gerrit-CC: Forest Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/brox: Create lotso variant
by Karthik Ramasubramanian (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Jian Tong, Kun Liu, Shelley Chen. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email ) Change subject: mb/google/brox: Create lotso variant ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b Gerrit-Change-Number: 81817 Gerrit-PatchSet: 6 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 16:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86: Enable long mode entry into payload for x86_64 support
by Arthur Heymans (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Subrata Banik. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email ) Change subject: arch/x86: Enable long mode entry into payload for x86_64 support ...................................................................... Patch Set 2: (1 comment) File src/arch/x86/boot.c: https://review.coreboot.org/c/coreboot/+/81960/comment/2eec302d_419cb3fe : PS1, Line 25: if (CONFIG(PAYLOAD_X86_64_SUPPORT)) { > > > > > > > Would it be possible to make it an offset? Then we could have a 32-bit entry > > > > > > > point followed by a 64-bit one, and a coreboot that knows the new ABI could skip > > > > > > > the first and jump directly to the new entry point. This would allow the most > > > > > > > compatibility between coreboot and payloads, as we could say the 64-bit entry > > > > > > > point is optional on both ends (except for X86S, ofc.). > > > > > > > > > > > > > > I guess the complexity of such a 32-bit entry point, that switches to long mode, > > > > > > > would depend a lot on the expectations on page tables in the new ABI. > > > > > > > > > > > > > > > > I guess a minimal expectation of at least 4G identity mapped is reasonable. Iirc UPL does that too. I like the idea of multiple entry points over a CBFS attribute as it's indeed the best way to be remain compatible. Linux already has exactly this btw. Question remains on how to achieve this? Have an expectation on the namespace in the ELF file which cbfstool can pick up? .text._entry64? > > > > > > > > can we review CB:81964 that adds the payload cbfs attribute for 64-bit. Then this CL has now updated to fetch the cbfs attribute rather reading any static Kconfig. > > > > > > following kernel concurrent 32-bit and 64-bit entry implementation may not be desired in AP FW as out configuration are very much static. We have to anyway select Kconfig in SoC to know if we are building 32-bit coreboot vs 64-bit coreboot hence, rather than complicating the flow, not sure what else we will bring by adding kernel like implementation while transferring control from coreboot to payload. > > > > > > > My previous comment explained that building coreboot and payload together is not the only way of doing things and should not be assumed... Entering 64bit mode from in the payload itself with a 32bit entry point can be done in 12 instructions. That's not too complicated and should be considered with the dual entry point strategy. > > > > > Anyway, lets review this CL to ensure we have atleast some ways to launch 64-bit payload from a 64-bit coreboot w/o lowering into 32-bit mode. Later we can desire more scalable approach for handoff. btw, i will bring x64 support cls next for libpayload. > > > > Let's not rush this. An ABI needs to be well designed and well documented. I don't think the fix/improve later approach is good here, as it implies breaking the ABI that worked at some point. If you want a 64bit libpayload, maybe start with a 32bit entry point that jumps to 64bit, which should work as is. In the meanwhile let's have a discussion on the ML on what the ABI would look like? > > I respectfully disagree with your approach. > > The problem statement is straightforward: > > coreboot currently always enters payload/libpayload in 32-bit mode, even when Coreboot is built natively for 64-bit mode. As explained, we need to ensure that we have support for 64-bit direct entry without trunking. > Why do you need that without trunking? Are you talking about HW that does not have 32bit support or do you want to load/jump to the payload above 4G? > I agree with you that we should add things to the payload CBFS to make things dynamic so that Coreboot can decide to jump either directly into 64-bit mode or fall back to 32-bit. > > I am not sure what is being broken by this approach. We are enabling 64-bit mode for payload and testing it seamlessly in parallel to 32-bit entry. > If we decide on a multiple entry point approach, then you end up with 2 ways: one with multiple entry points and one with an attribute indicating in which mode the payload works. That's 2 ways to do the same and since ABI needs to be stable that's not a good situation. > If you wish to improve how the entry point should be handled in the future, that can be done separately. I am not sure why I need to hold off my activity or do things by your means. > Improving probably means breaking an ABI compatibility in the future. That's not a good idea. > As I stated earlier, I will provide the libpayload 64-bit support code so you can examine how the entry point would appear. I ask that you do not combine this effort with unified payload. Unified payload is still in the planning stages, but enabling 64-bit support in coreboot/payload has business value; thus, the priority should not be the same at your end as it is at mine. The unified payload stuff indeed should not trump your business needs and I'm not suggesting to wait for that to happen. However I do think that thoughtful design and discussion needs to happen around the introduction of a ABI, before moving forward. In my opinion that should be a priority before merging something that works. -- To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b Gerrit-Change-Number: 81960 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 18 Apr 2024 16:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Hide typec ACPI device if UCSI is supported
by Karthik Ramasubramanian (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Nick Vaccaro, Pavan Holla, Shelley Chen. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email ) Change subject: Hide typec ACPI device if UCSI is supported ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81967/comment/892ee6c1_5ae8aab6 : PS2, Line 7: Hide typec ACPI device if UCSI is supported Nit: `ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled.` https://review.coreboot.org/c/coreboot/+/81967/comment/b8062de4_7f8a545b : PS2, Line 9: remove We are not removing. Rather we are not filling the TypeC ACPI device when UCSI is enabled. So I will rephrase the commit message accordingly. https://review.coreboot.org/c/coreboot/+/81967/comment/e8f4b90a_10361f0a : PS2, Line 17: b/333074788 and https://crrev.com/c/5421069 track the corresponding EC : change to add CBI. : https://crrev.com/c/5416841 is the change for adding the feature flag These links probably are access controlled and hence the community may not have access to it. You can remove them. https://review.coreboot.org/c/coreboot/+/81967/comment/d612e29a_7eb233d0 : PS2, Line 23: Cq-Depend: chromium:5416841 File src/ec/google/chromeec/ec_acpi.c: https://review.coreboot.org/c/coreboot/+/81967/comment/147f2faa_452eb01a : PS2, Line 161: /* UCSI implementations do not require an ACPI device : * with mux info since the linux kernel doesn't set : * the muxes. */ Nit: Coreboot allows 96 chars per line. Also here is the guideline regarding multi-line comments - https://doc.coreboot.org/contributing/coding_style.html#commenting Specifically this can be updated as: ``` /* UCSI implementations do not require an ACPI device with mux info since the linux kernel doesn't set the muxes. */ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/81967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I67dff6445aa7ba3ba48a04d1df3541f880d09d0a Gerrit-Change-Number: 81967 Gerrit-PatchSet: 2 Gerrit-Owner: Pavan Holla <pholla(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Caveh Jalali <caveh(a)chromium.org> Gerrit-CC: Forest Mittelberg <bmbm(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Pavan Holla <pholla(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 18 Apr 2024 16:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[main]: gma tgl: Pcode CDCLK_PREPARE_FOR_CHANGE is not mandatory
by Anil Kumar K (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Angel Pons, Anil Kumar K, Dinesh Gehlot, Jeremy Compostella, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/69341?usp=email ) Change subject: gma tgl: Pcode CDCLK_PREPARE_FOR_CHANGE is not mandatory ...................................................................... Patch Set 47: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/69341?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I0514e404a7b580d1e35af7b39c1bd77183f11058 Gerrit-Change-Number: 69341 Gerrit-PatchSet: 47 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 16:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/protectli/vault_cml: use combo v1/v2 FSP
by Piotr Kubaj (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Piotr Król, Piotr Kubaj. Hello Krystian Hebel, Michał Kopeć, Michał Żygowski, Piotr Król, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81963?usp=email to look at the new patch set (#7). Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP ...................................................................... mb/protectli/vault_cml: use combo v1/v2 FSP Also switch configs to use combo v1/v2 FSP The reason for this change is to simplify configuration - instead of multiple targets for VP4630 and VP4650 or VP4670, it's now possible to have one target covering all VP46x0. Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- R configs/config.protectli_cml_vp46xx D configs/config.protectli_vp4630_vp4650 M src/mainboard/protectli/vault_cml/Kconfig M src/mainboard/protectli/vault_cml/Kconfig.name 4 files changed, 6 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/81963/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/81963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Gerrit-Change-Number: 81963 Gerrit-PatchSet: 7 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/protectli/vault_cml: use combo v1/v2 FSP
by Piotr Kubaj (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Krystian Hebel, Michał Żygowski, Piotr Król, Piotr Kubaj. Hello Krystian Hebel, Michał Żygowski, Piotr Król, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81963?usp=email to look at the new patch set (#6). Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP ...................................................................... mb/protectli/vault_cml: use combo v1/v2 FSP Also switch config to use combo v1/v2 FSP The reason for this change is to simplify configuration - instead of multiple targets for VP4630 and VP4650 or VP4670, it's now possible to have one target covering all VP46x0. Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- R configs/config.protectli_cml_vp46xx D configs/config.protectli_vp4630_vp4650 A configs/config.protectli_vp46xx_txt M src/mainboard/protectli/vault_cml/Kconfig M src/mainboard/protectli/vault_cml/Kconfig.name 5 files changed, 24 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/81963/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/81963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Gerrit-Change-Number: 81963 Gerrit-PatchSet: 6 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/protectli/vault_cml: use combo v1/v2 FSP
by Piotr Kubaj (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Krystian Hebel, Michał Żygowski, Piotr Król, Piotr Kubaj. Hello Krystian Hebel, Michał Kopeć, Michał Żygowski, Piotr Król, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81963?usp=email to look at the new patch set (#5). Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP ...................................................................... mb/protectli/vault_cml: use combo v1/v2 FSP Also switch configs to use combo v1/v2 FSP The reason for this change is to simplify configuration - instead of multiple targets for VP4630 and VP4650 or VP4670, it's now possible to have one target covering all VP46x0. Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- R configs/config.protectli_cml_vp46xx D configs/config.protectli_vp4630_vp4650 A configs/config.protectli_vp46xx_txt M src/mainboard/protectli/vault_cml/Kconfig M src/mainboard/protectli/vault_cml/Kconfig.name 5 files changed, 24 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/81963/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/81963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Gerrit-Change-Number: 81963 Gerrit-PatchSet: 5 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: configs/config.protectli_vault_cml*: update for combo v1/v2 FSP
by Piotr Kubaj (Code Review) 18 Apr '24

18 Apr '24

Piotr Kubaj has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81962?usp=email ) Change subject: configs/config.protectli_vault_cml*: update for combo v1/v2 FSP ...................................................................... Abandoned Squashed into https://review.coreboot.org/c/coreboot/+/81963 -- To view, visit https://review.coreboot.org/c/coreboot/+/81962?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I096f746cc822451ea4f889a50329bd48576c2fa9 Gerrit-Change-Number: 81962 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <miczyg94(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[main]: mb/protectli/vault_cml: use combo v1/v2 FSP
by Piotr Kubaj (Code Review) 18 Apr '24

18 Apr '24

Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Piotr Król, Piotr Kubaj. Hello Krystian Hebel, Michał Kopeć, Michał Żygowski, Piotr Król, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81963?usp=email to look at the new patch set (#4). Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP ...................................................................... mb/protectli/vault_cml: use combo v1/v2 FSP Also switch configs to use combo v1/v2 FSP The reason for this change is to simplify configuration - instead of multiple targets for VP4630 and VP4650 or VP4670, it's now possible to have one target covering all VP46x0. Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A configs/config.protectli_cml_vp46xx D configs/config.protectli_vp4630_vp4650 D configs/config.protectli_vp4670 A configs/config.protectli_vp46xx_txt M src/mainboard/protectli/vault_cml/Kconfig M src/mainboard/protectli/vault_cml/Kconfig.name 6 files changed, 88 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/81963/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/81963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Gerrit-Change-Number: 81963 Gerrit-PatchSet: 4 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024