Attention is currently required from: Kun Liu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email )
Change subject: mb/google/brox: Create lotso variant
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> ouch, CB:81945 interfered with this one. […]
If we can add an empty hda_verb table, it'd be nice.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Gerrit-Change-Number: 81817
Gerrit-PatchSet: 7
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 18:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Kun Liu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email )
Change subject: mb/google/brox: Create lotso variant
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> > src/mainboard/google/brox/hda_verb.c:3:10: fatal error: 'variant/hda_verb.h' file not found […]
ouch, CB:81945 interfered with this one. so which one should we revert? or just add one of the hda tables to this variant?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Gerrit-Change-Number: 81817
Gerrit-PatchSet: 7
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 18:20:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Jean Lucas, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nicholas Chin, Nico Huber, Sean Rhodes.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I'm not sure on the performance gain. It's set as an interrupt handler, so it may be pretty hot code, but have its time cost split throughout all drivers. But on the other hand, it's just some interrupts. There are probably other things with greater time complexity (DEBUG images, for example, both in loading the binaries, as well as using the debug libraries).
Also, did you mean to keep this comment unresolved?
> Yes, I thought it should be added to the commit message or Kconfig help, but I sent it before I decided that Kconfig was best: to tell users. Then I sent the follow-up before I refreshed, so I didn't see your comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 5
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Jean Lucas
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 18:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Aseda Aboagye, Cliff Huang, Forest Mittelberg, Lance Zhao, Tim Wawrzynczak.
Hello Caveh Jalali, Cliff Huang, Forest Mittelberg, Jonathon Hall, Lance Zhao, Paul Menzel, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81996?usp=email
to look at the new patch set (#5).
Change subject: acpigen_ps2_keybd: Add assistant key to linux,keymap
......................................................................
acpigen_ps2_keybd: Add assistant key to linux,keymap
If the ChromiumOS EC indicates that the device has an assistant key,
we should also add it to the generated linux,keymap binding. This
commit simply does so by examining the keyboard capabilities reported by
the EC.
BUG=b:333088656
TEST=With a device that has an assistant key, flash AP FW and verify
that the key is mapped to `KEY_ASSISTANT` in the Linux kernel using
`evtest`.
Change-Id: I217220e89bce88e3045a4fc3b124954696276442
Signed-off-by: Aseda Aboagye <aaboagye(a)google.com>
---
M src/acpi/acpigen_ps2_keybd.c
M src/ec/google/chromeec/ec_acpi.c
M src/include/acpi/acpigen_ps2_keybd.h
M src/mainboard/purism/librem_jsl/ramstage.c
4 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/81996/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81996?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I217220e89bce88e3045a4fc3b124954696276442
Gerrit-Change-Number: 81996
Gerrit-PatchSet: 5
Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email )
Change subject: mb/google/brox: Create lotso variant
......................................................................
mb/google/brox: Create lotso variant
Create the lotso variant of the brox reference board by copying
the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:333494257
BRANCH=None
TEST=util/abuild/abuild -p none -t google/brox -x -a
make sure the build includes GOOGLE_LOTSO
Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81817
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Eric Lai <ericllai(a)google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
---
M src/mainboard/google/brox/Kconfig
M src/mainboard/google/brox/Kconfig.name
A src/mainboard/google/brox/variants/lotso/include/variant/ec.h
A src/mainboard/google/brox/variants/lotso/include/variant/gpio.h
A src/mainboard/google/brox/variants/lotso/memory/Makefile.mk
A src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt
A src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt
A src/mainboard/google/brox/variants/lotso/overridetree.cb
8 files changed, 47 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Karthik Ramasubramanian: Looks good to me, approved
Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig
index 9bc71ca..0ec5220 100644
--- a/src/mainboard/google/brox/Kconfig
+++ b/src/mainboard/google/brox/Kconfig
@@ -64,6 +64,9 @@
select CHROMEOS_WIFI_SAR if CHROMEOS
select SOC_INTEL_STORE_ISH_FW_VERSION
+config BOARD_GOOGLE_LOTSO
+ select BOARD_GOOGLE_BASEBOARD_BROX
+
config BOARD_GOOGLE_GREENBAYUPOC
select BOARD_GOOGLE_BASEBOARD_BROX
@@ -117,10 +120,12 @@
config MAINBOARD_PART_NUMBER
default "Brox_Ec_Ish" if BOARD_GOOGLE_BROX_EC_ISH
default "Brox" if BOARD_GOOGLE_BROX
+ default "Lotso" if BOARD_GOOGLE_LOTSO
default "Greenbayupoc" if BOARD_GOOGLE_GREENBAYUPOC
config VARIANT_DIR
default "brox" if BOARD_GOOGLE_BROX || BOARD_GOOGLE_BROX_EC_ISH
+ default "lotso" if BOARD_GOOGLE_LOTSO
default "greenbayupoc" if BOARD_GOOGLE_GREENBAYUPOC
config VBOOT
diff --git a/src/mainboard/google/brox/Kconfig.name b/src/mainboard/google/brox/Kconfig.name
index 37fc310..ae8f5ea 100644
--- a/src/mainboard/google/brox/Kconfig.name
+++ b/src/mainboard/google/brox/Kconfig.name
@@ -8,5 +8,8 @@
config BOARD_GOOGLE_BROX_EC_ISH
bool "-> Brox EC ISH"
+config BOARD_GOOGLE_LOTSO
+ bool "-> Lotso"
+
config BOARD_GOOGLE_GREENBAYUPOC
bool "-> Greenbayupoc"
diff --git a/src/mainboard/google/brox/variants/lotso/include/variant/ec.h b/src/mainboard/google/brox/variants/lotso/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/brox/variants/lotso/include/variant/gpio.h b/src/mainboard/google/brox/variants/lotso/include/variant/gpio.h
new file mode 100644
index 0000000..c4fe342
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/include/variant/gpio.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+#endif
diff --git a/src/mainboard/google/brox/variants/lotso/memory/Makefile.mk b/src/mainboard/google/brox/variants/lotso/memory/Makefile.mk
new file mode 100644
index 0000000..eace2e4
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/memory/Makefile.mk
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+
+SPD_SOURCES = placeholder
diff --git a/src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt b/src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt
new file mode 100644
index 0000000..fa24790
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt
@@ -0,0 +1 @@
+DRAM Part Name ID to assign
diff --git a/src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt b/src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt
new file mode 100644
index 0000000..2499005
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt
@@ -0,0 +1,11 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Generated IDs are dependent on the order of parts in this file,
+# so new parts must always be added at the end of the file!
+#
+# Generate an updated Makefile.mk and dram_id.generated.txt by running the
+# part_id_gen tool from util/spd_tools.
+# See util/spd_tools/README.md for more details and instructions.
+
+# Part Name
diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb
new file mode 100644
index 0000000..4f2c04a
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/alderlake
+
+ device domain 0 on
+ end
+
+end
--
To view, visit https://review.coreboot.org/c/coreboot/+/81817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Gerrit-Change-Number: 81817
Gerrit-PatchSet: 7
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81895?usp=email )
Change subject: acpigen_ps2_keybd: Add Fn key to linux,keymap
......................................................................
acpigen_ps2_keybd: Add Fn key to linux,keymap
Some devices may generate scancodes for the Fn key if they have one.
If they do, we should add them to the linux,keymap binding.
BUG=b:333096023
TEST=Flash DUT that emits a scancode for the Fn key, verify that it is
mapped to KEY_FN in the Linux kernel using `evtest` when pressing the Fn
key.
Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c
Signed-off-by: Aseda Aboagye <aaboagye(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81895
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Shelley Chen <shchen(a)google.com>
---
M src/acpi/Kconfig
M src/acpi/acpigen_ps2_keybd.c
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Shelley Chen: Looks good to me, approved
diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig
index 417ff60..2bb56ba 100644
--- a/src/acpi/Kconfig
+++ b/src/acpi/Kconfig
@@ -14,6 +14,14 @@
Specifies the ACPI name format string used by the acpigen
function to generate the processor scope. Default is CPxx.
+config ACPI_FNKEY_GEN_SCANCODE
+ int
+ default 0
+ help
+ Specifies the scancode, if any, which is generated when the Fn key is
+ pressed. A value of 0 is ignored, which is the default since most
+ keyboards do not emit a scancode for the Fn key.
+
config ACPI_HAVE_PCAT_8259
def_bool y if !ACPI_NO_PCAT_8259
diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c
index 6590e66..cc21d5d 100644
--- a/src/acpi/acpigen_ps2_keybd.c
+++ b/src/acpi/acpigen_ps2_keybd.c
@@ -244,6 +244,13 @@
acpi_dp_add_integer(dp_array, NULL, keymap);
}
+ /* Add the Fn-key */
+ if (CONFIG_ACPI_FNKEY_GEN_SCANCODE != 0) {
+ acpi_dp_add_integer(dp_array, NULL, KEYMAP(CONFIG_ACPI_FNKEY_GEN_SCANCODE,
+ KEY_FN));
+ total++;
+ }
+
total += num_top_row_keys;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/81895?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c
Gerrit-Change-Number: 81895
Gerrit-PatchSet: 5
Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged
Attention is currently required from: Andrey Petrov, Appukuttan V K, Paul Menzel, Ronak Kanabar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81663?usp=email )
Change subject: drivers/intel/fsp2_0: Add dedicated caller function for ap procedure calls
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81663/comment/f0d2e927_6576b0f1 :
PS5, Line 11: the appropriate C calling convention.
two things
1. please specify the BUG in this patch train w/o failing
2. Please specify test statement highlighting both 32-bit and 64-bit results.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81663?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64e65b2941207375d5e27c84aa26061e7e72a7f6
Gerrit-Change-Number: 81663
Gerrit-PatchSet: 5
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 16:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment