Attention is currently required from: Alexander Couzens, Alexei Sorokin.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80468?usp=email
to look at the new patch set (#2).
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
mb/lenovo/x230: Disable the USB P8 port
This port is not connected on the X230, X230i, X230t.
When X230 support was introduced and pei_data was filled in, this port
was disabled, but after https://review.coreboot.org/c/coreboot/+/6923 it
has become enabled.
Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Signed-off-by: Alexei Sorokin <sor.alexei(a)meowr.ru>
---
M src/mainboard/lenovo/x230/variants/x230/early_init.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/80468/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Alexei Sorokin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
mb/lenovo/x230: Disable the USB P8 port
This port is not connected on the X230, X230i, X230t.
When X230 support was introduced and pei_data was filled in, this port was
disabled, but after https://review.coreboot.org/c/coreboot/+/6923 it has become
enabled.
Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
---
M src/mainboard/lenovo/x230/variants/x230/early_init.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/80468/1
diff --git a/src/mainboard/lenovo/x230/variants/x230/early_init.c b/src/mainboard/lenovo/x230/variants/x230/early_init.c
index 7084e9a..55a3c08 100644
--- a/src/mainboard/lenovo/x230/variants/x230/early_init.c
+++ b/src/mainboard/lenovo/x230/variants/x230/early_init.c
@@ -12,7 +12,7 @@
{ 1, 1, -1 }, /* P5: Expresscard, no OC */
{ 0, 0, -1 }, /* P6: Empty */
{ 1, 2, -1 }, /* P7: dock, no OC */
- { 1, 0, -1 },
+ { 0, 0, -1 }, /* P8: Empty */
{ 1, 2, 5 }, /* P9: Right (EHCI debug), OC 5 */
{ 1, 1, -1 }, /* P10: fingerprint reader, no OC */
{ 1, 1, -1 }, /* P11: bluetooth, no OC. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-MessageType: newchange
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80492?usp=email )
Change subject: mb/google/dedede/Kconfig.name: Alphabetize board listing
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80492?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7230bb8f9883f186c10f41132a2919c3fd99f8c1
Gerrit-Change-Number: 80492
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 22:32:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80491?usp=email )
Change subject: mb/google/dedede/Kconfig: Alphabetize selections for baseboards
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80491?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I245eb8a9961e3e0025c0275f306a4d989b532331
Gerrit-Change-Number: 80491
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 22:31:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80490?usp=email )
Change subject: mb/google/dedede/Kconfig: Alphabetize variant board listings
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80490?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2909375d38c37332293bd7928ae33d5bb502694f
Gerrit-Change-Number: 80490
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 22:31:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Angel Pons, Charles Moyes, Felix Singer, Heiki Lõhmus, Kilian Neuner, Nico Huber, Paul Menzel, Xue Yao, insurgo(a)riseup.net.
Alexei Sorokin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: lenovo/x230: introduce EDP variant
......................................................................
Patch Set 25:
(4 comments)
Patchset:
PS22:
> On top of 4.19, I had to modify patch obtained by […]
Done
Patchset:
PS25:
Fixed the wrong path to VBT.
File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/28950/comment/09d48ef6_f7ff52ad :
PS19, Line 26: select GFX_GMA_PANEL_1_ON_EDP if BOARD_LENOVO_X230_EDP
> `_EDP` here means the dedicated eDP port. I assume this needs a `DP3` […]
Done
File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/28950/comment/694c156e_697f2761 :
PS22, Line 66: default "variants/x230_edp/data.vbt" if BOARD_LENOVO_X230_EDP
> Right. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 25
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kilian Neuner <cb(a)9-r.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: insurgo(a)riseup.net
Gerrit-Comment-Date: Tue, 13 Feb 2024 22:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: insurgo(a)riseup.net
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Alexei Sorokin, Angel Pons, Charles Moyes, Felix Singer, Heiki Lõhmus, Kilian Neuner, Nico Huber, Paul Menzel, Xue Yao, insurgo(a)riseup.net.
Alexei Sorokin has uploaded a new patch set (#25) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: lenovo/x230: introduce EDP variant
......................................................................
lenovo/x230: introduce EDP variant
There is a modification for the x230 which uses the 2nd DP from the dock
as the integrated panel's connection, which allows using a custom eDP
panel instead of the stock LVDS display.
There are several adapter boards present on the market and all of them
uses the same method of enabling the custom eDP panel.
To make this work with coreboot, the internal LVDS connector should be
disabled in libgfxinit. The VBT has been modified as well, which allows
brightness controls to work out of the box.
The modifications done to the VBT are:
- Remove the LVDS port entry.
- Move the DP-3 (which is the 2nd DP on the dock) entry to the first
position on the list.
- Set the DP-3 as internally connected.
This has been reported to work with the following panels:
- LP125WF2-SPB4 (1920*1080, 12.5")
- LQ125T1JW02 (2560*1440, 12.5")
- LQ133M1JW21 (1920*1080, 13.3")
- LTN133HL10-201 (1920*1080, 13.3")
- B133HAN04.6 (1920*1080, 13.3")
- B133QAN02.0 (2560*1600, 13.3")
Other eDP panels not on this list should work as well.
Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu>
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Signed-off-by: Alexei Sorokin <sor.alexei(a)meowr.ru>
---
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/lenovo/x230/Kconfig.name
M src/mainboard/lenovo/x230/Makefile.mk
A src/mainboard/lenovo/x230/variants/x230_edp/data.vbt
A src/mainboard/lenovo/x230/variants/x230_edp/gma-mainboard.ads
5 files changed, 38 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/25
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 25
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kilian Neuner <cb(a)9-r.net>
Gerrit-Attention: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: insurgo(a)riseup.net
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Angel Pons, Charles Moyes, Felix Singer, Heiki Lõhmus, Kilian Neuner, Nico Huber, Paul Menzel, Xue Yao, insurgo(a)riseup.net.
Alexei Sorokin has uploaded a new patch set (#24) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: lenovo/x230: introduce EDP variant
......................................................................
lenovo/x230: introduce EDP variant
There is a modification for the x230 which uses the 2nd DP from the dock
as the integrated panel's connection, which allows using a custom eDP
panel instead of the stock LVDS display.
There are several adapter boards present on the market and all of them
uses the same method of enabling the custom eDP panel.
To make this work with coreboot, the internal LVDS connector should be
disabled in libgfxinit. The VBT has been modified as well, which allows
brightness controls to work out of the box.
The modifications done to the VBT are:
- Remove the LVDS port entry.
- Move the DP-3 (which is the 2nd DP on the dock) entry to the first
position on the list.
- Set the DP-3 as internally connected.
This has been reported to work with the following panels:
- LP125WF2-SPB4 (1920*1080, 12.5")
- LQ125T1JW02 (2560*1440, 12.5")
- LQ133M1JW21 (1920*1080, 13.3")
- LTN133HL10-201 (1920*1080, 13.3")
- B133HAN04.6 (1920*1080, 13.3")
- B133QAN02.0 (2560*1600, 13.3")
Other eDP panels not on this list should work as well.
Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu>
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/lenovo/x230/Kconfig.name
M src/mainboard/lenovo/x230/Makefile.mk
A src/mainboard/lenovo/x230/variants/x230_edp/gma-mainboard.ads
4 files changed, 38 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/24
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 24
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kilian Neuner <cb(a)9-r.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: insurgo(a)riseup.net
Gerrit-MessageType: newpatchset
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Patryk Duda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80457?usp=email )
Change subject: mb/google/rex: Do not power on FPMCU in ramstage
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80457/comment/2103561a_8bbae790 :
PS1, Line 7: Do not power on FPMCU in ramstage
> is there any boot latency being observed as the device stays in off state for entire coreboot phase […]
No, I don't think so. The same approach (the FPMCU powered on by the kernel) is applied in brya devices.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80457?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5df8d9385be2621c02ccee2d36511a4e80ab87d1
Gerrit-Change-Number: 80457
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Duda <patrykd(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 21:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth.
Hello Arthur Heymans, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79934?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+2 by Arthur Heymans, Code-Review+2 by Martin L Roth, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: util/showdevicetree: drop unmaintained tool
......................................................................
util/showdevicetree: drop unmaintained tool
This tool doesn't have a makefile, when trying to compile it manually
with the given instructions it even fails to compile after fixing the
paths in the given command, and it references the non-existing
PCI_BUS_SEGN_BITS Kconfig symbol, so just drop this.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I8ca75db281a215bf3f194ab72a107f666dc0694e
---
M Documentation/util.md
M util/README.md
D util/showdevicetree/description.md
D util/showdevicetree/showdt.c
4 files changed, 0 insertions(+), 159 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/79934/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/79934?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ca75db281a215bf3f194ab72a107f666dc0694e
Gerrit-Change-Number: 79934
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset