Attention is currently required from: Michał Żygowski, Piotr Król.
Hello Piotr Król, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80501?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670
......................................................................
mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670
It is a new incoming Protectli product based on Alder Lake-P SoC.
More details and documentaion will be added later.
TEST=Boot Ubuntu 22.04 LTS and Windows 11 on VP6670.
Change-Id: If4ae5b14b69806b6b0727d1ca1dcf56f47cfcd8e
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
A src/mainboard/protectli/vault_adl_p/Kconfig
A src/mainboard/protectli/vault_adl_p/Kconfig.name
A src/mainboard/protectli/vault_adl_p/Makefile.inc
A src/mainboard/protectli/vault_adl_p/acpi/superio.asl
A src/mainboard/protectli/vault_adl_p/board_info.txt
A src/mainboard/protectli/vault_adl_p/bootblock.c
A src/mainboard/protectli/vault_adl_p/data.vbt
A src/mainboard/protectli/vault_adl_p/devicetree.cb
A src/mainboard/protectli/vault_adl_p/die.c
A src/mainboard/protectli/vault_adl_p/dsdt.asl
A src/mainboard/protectli/vault_adl_p/gpio.c
A src/mainboard/protectli/vault_adl_p/gpio.h
A src/mainboard/protectli/vault_adl_p/hda_verb.c
A src/mainboard/protectli/vault_adl_p/mainboard.c
A src/mainboard/protectli/vault_adl_p/romstage_fsp_params.c
A src/mainboard/protectli/vault_adl_p/vboot-rwa.fmd
16 files changed, 1,470 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/80501/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80501?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4ae5b14b69806b6b0727d1ca1dcf56f47cfcd8e
Gerrit-Change-Number: 80501
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Alexei Sorokin.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Attention: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 12:54:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80500?usp=email )
Change subject: soc/alderlake/romstage: Set UsbTcPortEnPreMem UPD based on devicetree
......................................................................
soc/alderlake/romstage: Set UsbTcPortEnPreMem UPD based on devicetree
The UsbTcPortEn UPD for FSP-S is being set in ramstage, however the
equivalent FSP-M UPD, the UsbTcPortEnPreMem, was not being set.
Following the Meteor Lake example, set the UsbTcPortEnPreMem UPD
as well for Alder Lake.
Change-Id: If3b79167ec1769ddfb7d28a6c78a3e80bd10afe7
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M src/soc/intel/alderlake/romstage/fsp_params.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/80500/1
diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c
index 84f83e3..d917e6c 100644
--- a/src/soc/intel/alderlake/romstage/fsp_params.c
+++ b/src/soc/intel/alderlake/romstage/fsp_params.c
@@ -271,6 +271,11 @@
m_cfg->TcssDma0En = is_devfn_enabled(SA_DEVFN_TCSS_DMA0);
m_cfg->TcssDma1En = is_devfn_enabled(SA_DEVFN_TCSS_DMA1);
+ m_cfg->UsbTcPortEnPreMem = 0;
+ for (int i = 0; i < MAX_TYPE_C_PORTS; i++)
+ if (config->tcss_ports[i].enable)
+ m_cfg->UsbTcPortEnPreMem |= BIT(i);
+
#if (CONFIG(SOC_INTEL_RAPTORLAKE) && !CONFIG(FSP_USE_REPO)) || \
(!CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) && CONFIG(FSP_USE_REPO))
m_cfg->DisableDynamicTccoldHandshake =
--
To view, visit https://review.coreboot.org/c/coreboot/+/80500?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If3b79167ec1769ddfb7d28a6c78a3e80bd10afe7
Gerrit-Change-Number: 80500
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange
Michał Żygowski has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/80497?usp=email )
Change subject: superio/ite/it8659e: Add driver for ITE IT8659E
......................................................................
superio/ite/it8659e: Add driver for ITE IT8659E
Based on the non-public "ITE IT8659E-I Preliminary Specification V0.7.2
(For H Version)".
TEST=Initialize IT8659E on the new Protectli platform
Change-Id: I11657ec6e1c880f0cee247071486a904a92bb7a1
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M src/superio/ite/Makefile.mk
A src/superio/ite/it8659e/Kconfig
A src/superio/ite/it8659e/Makefile.inc
A src/superio/ite/it8659e/acpi/superio.asl
A src/superio/ite/it8659e/chip.h
A src/superio/ite/it8659e/it8659e.h
A src/superio/ite/it8659e/superio.c
7 files changed, 345 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/80497/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80497?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11657ec6e1c880f0cee247071486a904a92bb7a1
Gerrit-Change-Number: 80497
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: mb/lenovo/x230: introduce EDP variant
......................................................................
Patch Set 27:
(1 comment)
File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/28950/comment/63da0a1a_35289480 :
PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"
> Done
this hasn't been addressed. don't mark things as resolved before they are resolved
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 27
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 12:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivan V <ivv(a)i1v.org>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Nicholas Sudsgaard.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80344?usp=email )
Change subject: superio/ite: Add IT8629E
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80344?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44d0377da11f0e118017caa4357012df9373b322
Gerrit-Change-Number: 80344
Gerrit-PatchSet: 8
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 14 Feb 2024 11:28:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment