Attention is currently required from: Alexander Couzens, Paul Menzel.
Alexei Sorokin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80468/comment/e33b2fe4_0f397d95 :
PS4, Line 12: was disabled, but after commit 3dc12c1e1918 it has become enabled.
> I’d write: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 5
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 18:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Alexei Sorokin, Paul Menzel.
Hello Alexander Couzens, Felix Held, Felix Singer, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80468?usp=email
to look at the new patch set (#5).
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
mb/lenovo/x230: Disable the USB P8 port
This port is not connected on the X230, X230i, X230t.
When X230 support was introduced and pei_data was filled in, this port
was disabled, but after commit 3dc12c1e1918
(bd82x6x: Consolidate early native USB init) it has become enabled.
Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Signed-off-by: Alexei Sorokin <sor.alexei(a)meowr.ru>
---
M src/mainboard/lenovo/x230/variants/x230/early_init.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/80468/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 5
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Alexei Sorokin, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80468/comment/073483bf_51741429 :
PS4, Line 9: This port is not connected on the X230, X230i, X230t.
> According to the Dasher-2 and Comet-2 Block Diagrams, page 28 in both cases.
I've rechecked with the schematics. Port 8 is unused.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 17:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: mb/lenovo/x230: introduce EDP variant
......................................................................
Patch Set 27:
(1 comment)
File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/28950/comment/09338365_bc25e0df :
PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"
> As people pointed out, existence of an incompatible mod is unconfirmed as if they use eDP for output […]
"Please add a help text about tested mods and their configuration." <- that's the part that's still missing and that probably should be added in a follow-up patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 27
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 16:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivan V <ivv(a)i1v.org>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Alexei Sorokin <sor.alexei(a)meowr.ru>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Paul Menzel.
Alexei Sorokin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80468/comment/54927b1a_25b90469 :
PS4, Line 9: This port is not connected on the X230, X230i, X230t.
> According to what source?
According to the Dasher-2 and Comet-2 Block Diagrams, page 28 in both cases.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 15:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Alexei Sorokin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80468/comment/40f41f07_c99bcd40 :
PS4, Line 9: This port is not connected on the X230, X230i, X230t.
According to what source?
https://review.coreboot.org/c/coreboot/+/80468/comment/ad51aef3_7d10ed5c :
PS4, Line 12: was disabled, but after commit 3dc12c1e1918 it has become enabled.
I’d write:
> commit 3dc12c1e1918 (bd82x6x: Consolidate early native USB init)
Patchset:
PS4:
Welcome to coreboot, and thank you very much for the contribution.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Attention: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 15:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Paul Menzel.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80353?usp=email )
Change subject: mb/amd/birman: Add Birman+ board support for Phoenix SOC
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> I think Birman+ is different enough from birman that it deserves it's own top level board. […]
Birman and Birman+ are both FP8 platforms and hence Birman+ is added as a variant and not as a separate mainboard.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80353?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Gerrit-Change-Number: 80353
Gerrit-PatchSet: 7
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 14 Feb 2024 14:17:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens.
Alexei Sorokin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: mb/lenovo/x230: introduce EDP variant
......................................................................
Patch Set 27:
(1 comment)
File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/28950/comment/c517f906_eda55a3b :
PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"
> this hasn't been addressed. […]
As people pointed out, existence of an incompatible mod is unconfirmed as if they use eDP for output, then they're going to work. Regarding brightness control, either they use LVDS and then this target will work best because of patched VBT specifically for that, or they don't and it simply won't matter to them.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 27
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 13:25:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivan V <ivv(a)i1v.org>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Alexei Sorokin <sor.alexei(a)meowr.ru>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Piotr Król.
Hello Piotr Król, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80501?usp=email
to look at the new patch set (#3).
Change subject: mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670
......................................................................
mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670
It is a new incoming Protectli product based on Alder Lake-P SoC.
More details and documentation will be added later.
TEST=Boot Ubuntu 22.04 LTS and Windows 11 on VP6670.
Change-Id: If4ae5b14b69806b6b0727d1ca1dcf56f47cfcd8e
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
A src/mainboard/protectli/vault_adl_p/Kconfig
A src/mainboard/protectli/vault_adl_p/Kconfig.name
A src/mainboard/protectli/vault_adl_p/Makefile.inc
A src/mainboard/protectli/vault_adl_p/acpi/superio.asl
A src/mainboard/protectli/vault_adl_p/board_info.txt
A src/mainboard/protectli/vault_adl_p/bootblock.c
A src/mainboard/protectli/vault_adl_p/data.vbt
A src/mainboard/protectli/vault_adl_p/devicetree.cb
A src/mainboard/protectli/vault_adl_p/die.c
A src/mainboard/protectli/vault_adl_p/dsdt.asl
A src/mainboard/protectli/vault_adl_p/gpio.c
A src/mainboard/protectli/vault_adl_p/gpio.h
A src/mainboard/protectli/vault_adl_p/hda_verb.c
A src/mainboard/protectli/vault_adl_p/mainboard.c
A src/mainboard/protectli/vault_adl_p/romstage_fsp_params.c
A src/mainboard/protectli/vault_adl_p/vboot-rwa.fmd
16 files changed, 1,468 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/80501/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80501?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4ae5b14b69806b6b0727d1ca1dcf56f47cfcd8e
Gerrit-Change-Number: 80501
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jan Samek, Stefan Reinauer, Vojtech Vesely.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80432?usp=email )
Change subject: util/ifdtool.c: Fix long_options platform has argument
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80432/comment/72004bd9_4e0a0ffc :
PS1, Line 9: Currently there is different behavior between using short and long
: option. Long option causes Segmentation fault.
:
> I think it is safe just to say the flag `has_arg` was mistakingly set to `0` while the option appare […]
would probably be good to add that info to the commit message, right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80432?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d5c31c2b1da544cb73d9e213d463332fcdba7df
Gerrit-Change-Number: 80432
Gerrit-PatchSet: 2
Gerrit-Owner: Vojtech Vesely <vojtech.vesely(a)9elements.com>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: deleted
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Vojtech Vesely <vojtech.vesely(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 13:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Samek <jan.samek(a)siemens.com>
Gerrit-MessageType: comment