Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80598?usp=email )
Change subject: device/pnp_device: Skip init on disabled functions
......................................................................
device/pnp_device: Skip init on disabled functions
If a function defined in a device's pnp_info struct is explcitly
disabled in a board devicetree, we should not get/set/assign
any resources to that function.
TEST=build/boot purism/librem_cnl (Mini v2), inspect cbmem log
and verify PNP functions disabled in devicetree don't show up
in the log / don't cause any errors.
Change-Id: I5c9d5cf34947535bf249b91f78d6fabfb28729ea
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/device/pnp_device.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/80598/1
diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c
index f799530..a968d39 100644
--- a/src/device/pnp_device.c
+++ b/src/device/pnp_device.c
@@ -386,6 +386,10 @@
path.pnp.device = info[i].function;
dev = alloc_find_dev(base_dev->upstream, &path);
+ /* Don't initialize a disabled device. */
+ if (!dev->enabled)
+ continue;
+
/* Don't initialize a device multiple times. */
if (dev->ops)
continue;
--
To view, visit https://review.coreboot.org/c/coreboot/+/80598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5c9d5cf34947535bf249b91f78d6fabfb28729ea
Gerrit-Change-Number: 80598
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Held, Karthik Ramasubramanian, Kevin Yang, Paul Menzel.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80573?usp=email )
Change subject: mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80573?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I494a922d2b04dcf7bd35680f5d95f8463e225f2d
Gerrit-Change-Number: 80573
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:26:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Sean Rhodes, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80553?usp=email )
Change subject: soc/intel/common/block/dtt: Add ACPI stub for TCPU device
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/dtt/dtt.c:
https://review.coreboot.org/c/coreboot/+/80553/comment/a8d70cb3_7b75761b :
PS3, Line 26:
: /* Skip if DPTF driver in use */
: if (CONFIG(DRIVERS_INTEL_DPTF))
: return;
> Done
Hmm, this barely made a difference. Why not put it on top?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Gerrit-Change-Number: 80553
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:11:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Matt DeVillier, Michał Żygowski, Nick Vaccaro, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80562?usp=email )
Change subject: soc/intel/alderlake/acpi: Drop ACPI stub for SATA device
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80562?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic45a059f47a090aa1993e83884408a82826b30cf
Gerrit-Change-Number: 80562
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:06:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Karthik Ramasubramanian, Kevin Yang, Paul Menzel.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79887?usp=email )
Change subject: mb/google/dedede/var/beadrix: Generate SPD ID for supported memory part
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a6925395b52dc7aa5c0f93b8820099369db4dbf
Gerrit-Change-Number: 79887
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 17 Feb 2024 01:42:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77968?usp=email )
Change subject: treewide: Move list.h to commonlib
......................................................................
Patch Set 8:
(1 comment)
File payloads/libpayload/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/77968/comment/61f6d95b_6b2f5e04 :
PS8, Line 73: INCLUDES += -I$(coreboottop)/src/commonlib/include
Sorry for not noticing this earlier, but I think we also want this wrapped in `ifeq ($(CONFIG_LP_GPL),y)`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/77968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16eb7b743fb1d36301f0eda563a62364e7a9cfec
Gerrit-Change-Number: 77968
Gerrit-PatchSet: 8
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 00:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80575?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case
......................................................................
soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case
Commit 829e8e65b939 ("soc/intel: Use common codeflow for MP init")
brokes `USE_INTEL_FSP_MP_INIT' by making `init_cpus' function
static. This function needs to be accessible from
src/drivers/intel/fsp2_0/fsp_mpinit.c.
TEST=Verified on Meteor Lake rex board
Change-Id: Idb8cdfef7b4279da2c7dff344c95fe446a605934
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/soc/intel/common/block/cpu/mp_init.c
M src/soc/intel/common/block/include/intelblocks/mp_init.h
2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/80575/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80575?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb8cdfef7b4279da2c7dff344c95fe446a605934
Gerrit-Change-Number: 80575
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset