Attention is currently required from: Jonathon Hall, Matt DeVillier.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80602?usp=email )
Change subject: mb/purism/librem_cnl: Drop selection of USE_LEGACY_8254_TIMER
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80602?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I974a82bedc4e06f48ce801f2bc0c29afbd80ffcf
Gerrit-Change-Number: 80602
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:52:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathon Hall, Matt DeVillier.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80601?usp=email )
Change subject: mb/purism/librem_cnl/var/librem_mini: Set RTC register defaults
......................................................................
Patch Set 1: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80601/comment/8565cbdf_b126eca4 :
PS1, Line 9: Thee PNP resource allocator will throw an error in cbmem if the RTC
extra space
https://review.coreboot.org/c/coreboot/+/80601/comment/e6c21f0e_d751f232 :
PS1, Line 9: Thee
Thy?
https://review.coreboot.org/c/coreboot/+/80601/comment/9acd4f65_3e55a673 :
PS1, Line 11: set them to the currenett/default values to eliminatte the errors.
you might want to look over the whole commit message
https://review.coreboot.org/c/coreboot/+/80601/comment/dc92441f_a60fdd29 :
PS1, Line 11: currenett
current
--
To view, visit https://review.coreboot.org/c/coreboot/+/80601?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I310a834a1fa7b8428879fbc160e4aae0a519e063
Gerrit-Change-Number: 80601
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:51:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathon Hall, Matt DeVillier.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80600?usp=email )
Change subject: mb/purism_librem_cnl/var/*: Drop redundant device entries in overridetree
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80600/comment/381f102b_2c66ddd0 :
PS1, Line 7: overridetree
shorten this?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80600?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12498e7261dafd7ee59fe79926532399392d1b09
Gerrit-Change-Number: 80600
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathon Hall, Matt DeVillier.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80599?usp=email )
Change subject: mb/purism/librem_cnl: Drop devicetree entries identical to chipset.cb
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c656d227962548cebde61f1d82333837adbbf56
Gerrit-Change-Number: 80599
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:47:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Matt DeVillier, Nico Huber.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80598?usp=email )
Change subject: device/pnp_device: Skip init on disabled functions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5c9d5cf34947535bf249b91f78d6fabfb28729ea
Gerrit-Change-Number: 80598
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:46:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Sean Rhodes, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80553?usp=email )
Change subject: soc/intel/common/block/dtt: Add ACPI stub for TCPU device
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/dtt/dtt.c:
https://review.coreboot.org/c/coreboot/+/80553/comment/89a935b3_d1bccecd :
PS3, Line 26:
: /* Skip if DPTF driver in use */
: if (CONFIG(DRIVERS_INTEL_DPTF))
: return;
> Hmm, this barely made a difference. […]
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Gerrit-Change-Number: 80553
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jonathon Hall.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80602?usp=email )
Change subject: mb/purism/librem_cnl: Drop selection of USE_LEGACY_8254_TIMER
......................................................................
mb/purism/librem_cnl: Drop selection of USE_LEGACY_8254_TIMER
It's not needed other than for booting w/SeaBIOS, where it is already
selected by default, and enabling it with edk2 payload prevents Linux/
Windows from fully entering S0ix.
TEST=build/boot purism/librem_cnl (Mini v2), verify Win11/Linux able
to enter and exit S0ix properly.
Change-Id: I974a82bedc4e06f48ce801f2bc0c29afbd80ffcf
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/purism/librem_cnl/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/80602/1
diff --git a/src/mainboard/purism/librem_cnl/Kconfig b/src/mainboard/purism/librem_cnl/Kconfig
index 1628ec6..ee2f410 100644
--- a/src/mainboard/purism/librem_cnl/Kconfig
+++ b/src/mainboard/purism/librem_cnl/Kconfig
@@ -11,7 +11,6 @@
select SOC_INTEL_COMMON_BLOCK_HDA_VERB
select SPD_CACHE_IN_FMAP
select SPD_READ_BY_WORD
- select USE_LEGACY_8254_TIMER
config BOARD_PURISM_LIBREM_MINI
select BOARD_PURISM_BASEBOARD_LIBREM_CNL
--
To view, visit https://review.coreboot.org/c/coreboot/+/80602?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I974a82bedc4e06f48ce801f2bc0c29afbd80ffcf
Gerrit-Change-Number: 80602
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: newchange
Attention is currently required from: Jonathon Hall.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80601?usp=email )
Change subject: mb/purism/librem_cnl/var/librem_mini: Set RTC register defaults
......................................................................
mb/purism/librem_cnl/var/librem_mini: Set RTC register defaults
Thee PNP resource allocator will throw an error in cbmem if the RTC
does not have all 4 io registers and an IRQ register programmed, so
set them to the currenett/default values to eliminatte the errors.
TEST=build/boot purism/librem_cnl (Mini v2), verify RTC register values
unchanged before/after patch via superiotool, verify errors no longer
present in cbmem log.
Change-Id: I310a834a1fa7b8428879fbc160e4aae0a519e063
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/80601/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
index d2f1a83..c29c37b 100644
--- a/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
+++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
@@ -151,7 +151,11 @@
device pnp 2e.a off end # Consumer IR
device pnp 2e.f off end # Shared Memory/Flash Interface (SMFI)
device pnp 2e.10 on # RTC-like Timer
+ io 0x60 = 0x070
io 0x62 = 0x360 # BRAM1 I/O base address
+ io 0x64 = 0x0
+ io 0x66 = 0x0
+ irq 0x70 = 0x8
end
device pnp 2e.11 off end # Power Management I/F Channel 1 (PMC1)
device pnp 2e.12 off end # Power Management I/F Channel 2 (PMC2)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80601?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I310a834a1fa7b8428879fbc160e4aae0a519e063
Gerrit-Change-Number: 80601
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: newchange
Attention is currently required from: Jonathon Hall.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80600?usp=email )
Change subject: mb/purism_librem_cnl/var/*: Drop redundant device entries in overridetree
......................................................................
mb/purism_librem_cnl/var/*: Drop redundant device entries in overridetree
Now that the baseboard uses chipset devicetree references, remove
all references whose value is identical to the chipset devicetree
default or the baseboard default, since they are pointless clutter.
TEST=build/boot purism/librem_cnl (Mini v2), verify output of lspci
and lsusb unchanged before and after patch.
Change-Id: I12498e7261dafd7ee59fe79926532399392d1b09
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb
M src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
2 files changed, 0 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/80600/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb
index b3fd862..f522e66 100644
--- a/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb
+++ b/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb
@@ -55,21 +55,6 @@
device usb 2.2 on end
end
chip drivers/usb/acpi
- device usb 2.3 off end
- end
- chip drivers/usb/acpi
- device usb 2.4 off end
- end
- chip drivers/usb/acpi
- device usb 2.5 off end
- end
- chip drivers/usb/acpi
- register "desc" = ""Left Type-A Port""
- register "type" = "UPC_TYPE_A"
- register "group" = "ACPI_PLD_GROUP(1, 0)"
- device usb 2.6 off end
- end
- chip drivers/usb/acpi
register "desc" = ""Right Type-C Port""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(0, 1)"
@@ -82,9 +67,6 @@
device usb 2.8 on end
end
chip drivers/usb/acpi
- device usb 2.9 off end
- end
- chip drivers/usb/acpi
register "desc" = ""Right Type-A Port""
register "type" = "UPC_TYPE_A"
register "group" = "ACPI_PLD_GROUP(0, 0)"
@@ -97,15 +79,6 @@
device usb 3.1 on end
end
chip drivers/usb/acpi
- register "desc" = ""Right Type-C Port""
- register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
- register "group" = "ACPI_PLD_GROUP(0, 1)"
- device usb 3.2 off end
- end
- chip drivers/usb/acpi
- device usb 3.3 off end
- end
- chip drivers/usb/acpi
register "desc" = ""Left Type-C Port""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(1, 1)"
@@ -131,7 +104,6 @@
register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC2)" # Type-C left
register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Card Reader
end
- device ref xdci off end
device ref i2c0 on
chip drivers/i2c/hid
register "generic.hid" = ""HTIX5288""
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
index f9baef2..d2f1a83 100644
--- a/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
+++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb
@@ -60,15 +60,6 @@
device usb 2.5 on end
end
chip drivers/usb/acpi
- device usb 2.6 off end
- end
- chip drivers/usb/acpi
- device usb 2.7 off end
- end
- chip drivers/usb/acpi
- device usb 2.8 off end
- end
- chip drivers/usb/acpi
register "desc" = ""USB2 Type-A Rear Lower""
register "type" = "UPC_TYPE_A"
register "group" = "ACPI_PLD_GROUP(1, 1)"
@@ -87,9 +78,6 @@
device usb 3.1 on end
end
chip drivers/usb/acpi
- device usb 3.2 off end
- end
- chip drivers/usb/acpi
register "desc" = ""USB3 Type-C Rear""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(1, 2)"
--
To view, visit https://review.coreboot.org/c/coreboot/+/80600?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12498e7261dafd7ee59fe79926532399392d1b09
Gerrit-Change-Number: 80600
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: newchange
Attention is currently required from: Jonathon Hall.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80599?usp=email )
Change subject: mb/purism/librem_cnl: Drop devicetree entries identical to chipset.cb
......................................................................
mb/purism/librem_cnl: Drop devicetree entries identical to chipset.cb
Now that the board uses chipset devicetree references, remove all
references whose value is identical to the chipset devicetree default,
since they are pointless clutter.
TEST=build/boot purism/librem_cnl (Mini v2), run lspci and verify output
unchanged before and after patch.
Change-Id: I6c656d227962548cebde61f1d82333837adbbf56
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/purism/librem_cnl/devicetree.cb
1 file changed, 9 insertions(+), 49 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/80599/1
diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb
index 3d26b09..4db8cd9 100644
--- a/src/mainboard/purism/librem_cnl/devicetree.cb
+++ b/src/mainboard/purism/librem_cnl/devicetree.cb
@@ -44,58 +44,18 @@
device cpu_cluster 0 on end
device domain 0 on
- device ref system_agent on end
- device ref igpu on end
- device ref dptf on
+ device ref system_agent on end
+ device ref igpu on end
+ device ref dptf on
register "Device4Enable" = "1"
end
- device ref thermal on end
- device ref ish off end
- device ref xhci on end
- device ref xdci off end
- device ref i2c0 off end
- device ref i2c1 off end
- device ref i2c2 off end
- device ref i2c3 off end
- device ref heci1 off end
- device ref heci2 off end
- device ref csme_ider off end
- device ref csme_ktr off end
- device ref heci3 off end
- device ref heci4 off end
- device ref sata on end
- device ref i2c4 off end
- device ref i2c5 off end
- device ref uart2 off end
- device ref emmc off end
- device ref pcie_rp1 off end
- device ref pcie_rp2 off end
- device ref pcie_rp3 off end
- device ref pcie_rp4 off end
- device ref pcie_rp5 off end
- device ref pcie_rp6 off end
- device ref pcie_rp7 off end
- device ref pcie_rp8 off end
- device ref pcie_rp9 off end
- device ref pcie_rp10 off end
- device ref pcie_rp11 off end
- device ref pcie_rp12 off end
- device ref pcie_rp13 off end
- device ref pcie_rp14 off end
- device ref pcie_rp15 off end
- device ref pcie_rp16 off end
- device ref uart0 off end
- device ref uart1 off end
- device ref gspi0 off end
- device ref gspi1 off end
- device ref lpc_espi on end
- device ref p2sb off end
- device ref pmc hidden end
- device ref hda on
+ device ref thermal on end
+ device ref xhci on end
+ device ref sata on end
+ device ref hda on
register "PchHdaAudioLinkHda" = "1"
end
- device ref smbus on end
- device ref fast_spi on end
- device ref gbe off end
+ device ref smbus on end
+ device ref fast_spi on end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/80599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c656d227962548cebde61f1d82333837adbbf56
Gerrit-Change-Number: 80599
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: newchange