Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45319?usp=email )
Change subject: .gitmodules: Clean up names and paths.
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/45319?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56b457e6d7fa9e51ee5066136df44083487504d1
Gerrit-Change-Number: 45319
Gerrit-PatchSet: 1
Gerrit-Owner: Masanori Ogino <mogino(a)acm.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: Fix control flow DEADCODE issue
......................................................................
Fix control flow DEADCODE issue
Coverity detects DEADCODE issue in the control flow. Based on both of
KEMPLD_CLK and KEMPLD_I2C_FREQ_STD definitions, execution cannot reach
this statement "prescale = 0". This change removes the DEADCODE code.
Found-by: Coverity CID 1431154
TEST=None
Signed-off-by: John Zhao <john.zhao(a)intel.com>
Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
---
M src/ec/kontron/kempld/kempld_i2c.c
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45623/1
diff --git a/src/ec/kontron/kempld/kempld_i2c.c b/src/ec/kontron/kempld/kempld_i2c.c
index 296cf76..165c940 100644
--- a/src/ec/kontron/kempld/kempld_i2c.c
+++ b/src/ec/kontron/kempld/kempld_i2c.c
@@ -250,9 +250,6 @@
else
prescale = KEMPLD_CLK / (KEMPLD_I2C_FREQ_STD * 4) - 3000;
- if (prescale < 0)
- prescale = 0;
-
/* Round to the best matching value */
prescale_corr = prescale / 1000;
if (prescale % 1000 >= 500)
--
To view, visit https://review.coreboot.org/c/coreboot/+/45623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
Gerrit-Change-Number: 45623
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange