Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65420?usp=email )
Change subject: allocator_v4: Use memranges only for toplevel
......................................................................
Patch Set 21:
(1 comment)
File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/65420/comment/d9b1786f_76e4eeed :
PS7, Line 408: res->limit
Missing effective_limit(), fix in CB:76090.
--
To view, visit https://review.coreboot.org/c/coreboot/+/65420?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70c700318a85f6760f27597730bc9c9a86dbe6b3
Gerrit-Change-Number: 65420
Gerrit-PatchSet: 21
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Comment-Date: Fri, 23 Jun 2023 00:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Hello Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74770?usp=email
to look at the new patch set (#21).
Change subject: mainboard/google/rex: Enable crashlog
......................................................................
mainboard/google/rex: Enable crashlog
Enable crashlog for rex. Select config options SOC_INTEL_CRASHLOG,
and SOC_INTEL_IOE_DIE_SUPPORT. Also enable ioe_shared_sram and
pmc_shared_sram devices.
BUG=b:262501347
TEST=Able to trigger Crashlog, BERT table gets generated and decodes
as expected.
Change-Id: I3d3a9fb41d1293f021ad9de9b29c756cb7559373
Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com>
---
M src/mainboard/google/rex/Kconfig
M src/mainboard/google/rex/variants/rex0/overridetree.cb
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/74770/21
--
To view, visit https://review.coreboot.org/c/coreboot/+/74770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d3a9fb41d1293f021ad9de9b29c756cb7559373
Gerrit-Change-Number: 74770
Gerrit-PatchSet: 21
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Tim Van Patten.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/variants/baseboard:Update system_configuration
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 23:57:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Tim Van Patten.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/variants/baseboard:Update system_configuration
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Please help to review this change
--
To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 23:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Martin Roth.
Hello Jason Nien, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76091?usp=email
to look at the new patch set (#2).
Change subject: mb/google/skyrim/variants/baseboard:Update system_configuration
......................................................................
mb/google/skyrim/variants/baseboard:Update system_configuration
Update system_configuration to 3 for 15W. Specification "FT6
Infrastructure Roadmap"#57316" incorrectly lists system config index
should be 4 for 15W. Setting to 4 will cause an additional call to the
SMU that is not needed. Both SMU and FSP interpret configs > 3 as 3.
BUG=b:267294958
TEST=Confirm extra message is not sent in serial log.
Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.com>
---
M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76091/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Jason Glenesk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/variants/baseboard:Update system_configuration
......................................................................
mb/google/skyrim/variants/baseboard:Update system_configuration
Update system_configuration to 3 for 15W. Specification "FT6
Infrastructure Roadmap"#57316" incorrectly lists system config index
should be 4 for 15W. Setting to 4 will cause an additional call to the
SMU that is not needed. Both SMU and FSP interpret configs > 3 as 3.
Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.com>
---
M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76091/1
diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
index b605e1c..f24dc59 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
@@ -262,8 +262,8 @@
end
# DPTC: Refer the spec "FT6 Infrastructure Roadmap"#57316
- # Set system_configuration to 4 for 15W
- register "system_configuration" = "4"
+ # Set system_configuration to 3 for 15W
+ register "system_configuration" = "3"
# Normal
register "slow_ppt_limit_mW" = "25000"
register "fast_ppt_limit_mW" = "30000"
--
To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-MessageType: newchange