coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: util/cbfstool: Qualify struct e820entry as packed
by Lean Sheng Tan (Code Review) 16 Apr '23

16 Apr '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74270 ) Change subject: util/cbfstool: Qualify struct e820entry as packed ...................................................................... util/cbfstool: Qualify struct e820entry as packed In order to accord with grub (see include/grub/i386/linux.h) and comments for offsets of members of struct linux_params, struct e820entry should be defined as __packed, otherwise, sizeof(struct linux_params) will become 4224 (0x1080). Fortunately, the affected area is usually not occupied. Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: I09955c90e4eec337adca383e628a8821075381d6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74270 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M util/cbfstool/linux.h 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved diff --git a/util/cbfstool/linux.h b/util/cbfstool/linux.h index dc4575c..2905f35 100644 --- a/util/cbfstool/linux.h +++ b/util/cbfstool/linux.h @@ -27,7 +27,7 @@ #define E820_RESERVED 2 #define E820_ACPI 3 /* usable as RAM once ACPI tables have been read */ #define E820_NVS 4 -}; +} __packed; /* The header of Linux/i386 kernel */ struct linux_header { -- To view, visit https://review.coreboot.org/c/coreboot/+/74270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09955c90e4eec337adca383e628a8821075381d6 Gerrit-Change-Number: 74270 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook: Add ramtop_cmos_offset
by Lean Sheng Tan (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Sean Rhodes. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74432 ) Change subject: mb/starlabs/starbook: Add ramtop_cmos_offset ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7 Gerrit-Change-Number: 74432 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sun, 16 Apr 2023 13:59:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/mainboard/hp: Add more about internal flashing
by Václav Straka (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Nicholas Chin. Václav Straka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74248 ) Change subject: Documentation/mainboard/hp: Add more about internal flashing ...................................................................... Patch Set 6: (20 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74248/comment/5c209e64_1c4880dc PS5, Line 12: Vesek > https://coreboot.org/developers.html under Sign-off Procedure. […] Done File Documentation/mainboard/hp/compaq_8200_sff.md: https://review.coreboot.org/c/coreboot/+/74248/comment/13707846_6ea70d46 PS5, Line 36: ``` > I would add a blank line here after the ``` at the end of the table and the Flash layout header Done https://review.coreboot.org/c/coreboot/+/74248/comment/874d942b_3b8f377d PS5, Line 51: ``` > Nit: add a blank line after this Done https://review.coreboot.org/c/coreboot/+/74248/comment/ea47efbe_4031d0a2 PS5, Line 52: flash > flash, (comma) Done https://review.coreboot.org/c/coreboot/+/74248/comment/4c8df4a6_a15a6ce1 PS5, Line 53: region > Maybe add something like "due to SPI Protected Range settings" after this to describe why the bios r […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/39345a9b_0975d1bb PS5, Line 56: > Nit: Remove this blank line as the rendered output has a blank line between the caption and the imag […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/9b1b49e3_83826a8e PS5, Line 61: [IFD Hack](https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/7… > You can use the `[reference]: url` syntax for links so that you don't need to have a long URL inline […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/885ca800_45afaf6d PS5, Line 61: You can use a modified [IFD Hack](https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/7… originally used on MacBooks, you will : need to read both guides. > The wording of this sentence could be clearer. […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/1720b40b_858abc07 PS5, Line 64: write in the flash descriptor region you > ...write in the flash descriptor region, (comma) you... […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/592afc70_587fc3d0 PS5, Line 65: originaly > Spelling: originally Done https://review.coreboot.org/c/coreboot/+/74248/comment/5e4732aa_8e56e01b PS5, Line 66: flash > flash, (comma) Done https://review.coreboot.org/c/coreboot/+/74248/comment/214ffd90_65ce16bf PS5, Line 70: ME shrinked > Maybe "trucated ME firmware" or "neutered ME firmware" to more closely match the Macbook instruction […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/a06efdb4_057c17ee PS5, Line 77: ``` > Nit: Add a blank line after this Done https://review.coreboot.org/c/coreboot/+/74248/comment/faa912fc_4c3bb76e PS5, Line 78: brick > Maybe add "and require external flashing" after this so that it's clear that it isn't a permanent br […] Done https://review.coreboot.org/c/coreboot/+/74248/comment/3036e34d_00e8ab8b PS5, Line 79: should be already > should already be Done https://review.coreboot.org/c/coreboot/+/74248/comment/2bdbd9cc_0b835acf PS5, Line 79: got so far > got this far Done https://review.coreboot.org/c/coreboot/+/74248/comment/0ca0df3d_dfb89d52 PS5, Line 80: flash size > Maybe "ROM chip size" to match the appropriate menuconfig option Done https://review.coreboot.org/c/coreboot/+/74248/comment/ebe50d34_a9ac0230 PS5, Line 80: fill : the rest with zeros to get the matching size using > I would replace this with "pad the ROM to the required 8MB with zeros using:" Done https://review.coreboot.org/c/coreboot/+/74248/comment/0545017b_79b47f45 PS5, Line 94: ``` > Nit: Add a blank line after this Done https://review.coreboot.org/c/coreboot/+/74248/comment/f867f269_4a50c3ea PS5, Line 95: More about flashing internally and getting the flash layout [here](../../tutorial/flashing_firmware/index.md). > Please add a blank line between this and the "External programming" header Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53a697a2dd6c10fff8f287284f75d229c7c4b636 Gerrit-Change-Number: 74248 Gerrit-PatchSet: 6 Gerrit-Owner: Václav Straka Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 16 Apr 2023 12:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/mainboard/hp: Add more about internal flashing
by Václav Straka (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Nicholas Chin. Hello build bot (Jenkins), Nicholas Chin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74248 to look at the new patch set (#6). Change subject: Documentation/mainboard/hp: Add more about internal flashing ...................................................................... Documentation/mainboard/hp: Add more about internal flashing Add a more detailed explanation of internal flashing on the HP Compaq 8200 Elite SFF. Signed-off-by: Václav Straka <venda.straka(a)gmail.com> Change-Id: I53a697a2dd6c10fff8f287284f75d229c7c4b636 --- M Documentation/mainboard/hp/compaq_8200_sff.md A Documentation/mainboard/hp/compaq_8200_sff_jumper.jpg 2 files changed, 92 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/74248/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/74248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53a697a2dd6c10fff8f287284f75d229c7c4b636 Gerrit-Change-Number: 74248 Gerrit-PatchSet: 6 Gerrit-Owner: Václav Straka Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Documentation/mainboard/hp: Add more about internal flashing
by Václav Straka (Code Review) 16 Apr '23

16 Apr '23

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static
by Sridhar Siricilla (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Subrata Banik, Kapil Porwal, Dinesh Gehlot. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74388 ) Change subject: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac Gerrit-Change-Number: 74388 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Sun, 16 Apr 2023 07:28:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable CSE FPT Info config for Nissa
by Sridhar Siricilla (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Derek Huang, Kyle Lin, Kapil Porwal, Dinesh Gehlot. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74387 ) Change subject: mb/google/brya: Enable CSE FPT Info config for Nissa ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I234b5d272077de9a6f0a9ba69fa015cda7ebd56c Gerrit-Change-Number: 74387 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Sun, 16 Apr 2023 07:27:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/intel/ish: Hook get ISH version into `.final`
by Sridhar Siricilla (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Paul Menzel. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 ) Change subject: drivers/intel/ish: Hook get ISH version into `.final` ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 Gerrit-Change-Number: 74209 Gerrit-PatchSet: 18 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 16 Apr 2023 07:27:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Store ISH firmware version into CBMEM
by Kangheui Won (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Sridhar Siricilla, Arthur Heymans. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 ) Change subject: soc/intel/cmn/cse: Store ISH firmware version into CBMEM ...................................................................... Patch Set 21: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 21 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 16 Apr 2023 06:21:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM
by Kangheui Won (Code Review) 16 Apr '23

16 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Sridhar Siricilla, Arthur Heymans. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 ) Change subject: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8 Gerrit-Change-Number: 74256 Gerrit-PatchSet: 17 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 16 Apr 2023 05:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023