coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Disable thunderbolt ports
by Angel Pons (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Kevin Chiu, Tarun Tuli, Eric Lai, Ricky Chang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 ) Change subject: mb/google/brya/var/lisbon: Disable thunderbolt ports ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68916/comment/1eabebaf_52f4fbcd PS1, Line 9: no support thunderbolt on lisbon > Done Thank you! -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:31:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Disable thunderbolt ports
by Kevin Chiu (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Tarun Tuli, Angel Pons, Eric Lai, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 ) Change subject: mb/google/brya/var/lisbon: Disable thunderbolt ports ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68916/comment/cdb87938_dd72eab0 PS1, Line 9: no support thunderbolt on lisbon > sure, it's good to follow up. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Disable thunderbolt ports
by Kevin Chiu (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Tarun Tuli, Angel Pons, Eric Lai, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 ) Change subject: mb/google/brya/var/lisbon: Disable thunderbolt ports ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68916/comment/1d542427_dbf14fe8 PS1, Line 7: turn off thunderbolt > It doesn't seem like much, but could you please change it? […] Done https://review.coreboot.org/c/coreboot/+/68916/comment/2bb50947_218cd0b3 PS1, Line 9: no support thunderbolt on lisbon > Eric's suggestion is a well-formed sentence, though. […] sure, it's good to follow up. -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:30:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Disable thunderbolt ports
by Kevin Chiu (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Kevin Chiu, Tarun Tuli, Eric Lai, Ricky Chang. Hello build bot (Jenkins), Tarun Tuli, Angel Pons, Nick Vaccaro, Ricky Chang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68916 to look at the new patch set (#2). Change subject: mb/google/brya/var/lisbon: Disable thunderbolt ports ...................................................................... mb/google/brya/var/lisbon: Disable thunderbolt ports Lisbon doesn't support thunderbolt. BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 --- M src/mainboard/google/brya/variants/lisbon/overridetree.cb 1 file changed, 21 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/68916/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: sb/intel/lynxpoint: Add PCI DIDs for 9 series PCHs
by Angel Pons (Code Review) 06 Nov '22

06 Nov '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68187 ) Change subject: sb/intel/lynxpoint: Add PCI DIDs for 9 series PCHs ...................................................................... Patch Set 1: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/68187/comment/00538f30_7b3e97a3 PS1, Line 2840: #define PCI_DID_INTEL_LPT_H97 0x8cc6 > Might need to add them to report_platform somewhere. CB:69259 -- To view, visit https://review.coreboot.org/c/coreboot/+/68187 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee93fee4f28b88a72c537944159fb7cbb2796235 Gerrit-Change-Number: 68187 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/haswell: Add 9-series PCH IDs
by Angel Pons (Code Review) 06 Nov '22

06 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69259 ) Change subject: nb/intel/haswell: Add 9-series PCH IDs ...................................................................... nb/intel/haswell: Add 9-series PCH IDs Change-Id: I5b7b1c218a0e8c8ba713b370622fbc37a1e57097 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/haswell/report_platform.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/69259/1 diff --git a/src/northbridge/intel/haswell/report_platform.c b/src/northbridge/intel/haswell/report_platform.c index 0b5319b..d33902f 100644 --- a/src/northbridge/intel/haswell/report_platform.c +++ b/src/northbridge/intel/haswell/report_platform.c @@ -67,6 +67,11 @@ {0x8c54, "C224"}, {0x8c56, "C226"}, {0x8c5c, "H81"}, + {0x8cc1, "Mobile Engineering Sample (9 series)"}, + {0x8cc2, "Desktop Engineering Sample (9 series)"}, + {0x8cc3, "HM97"}, + {0x8cc4, "Z97"}, + {0x8cc6, "H97"}, {0x9c41, "LP Full Featured Engineering Sample"}, {0x9c43, "LP Premium"}, {0x9c45, "LP Mainstream"}, -- To view, visit https://review.coreboot.org/c/coreboot/+/69259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b7b1c218a0e8c8ba713b370622fbc37a1e57097 Gerrit-Change-Number: 69259 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: turn off thunderbolt
by Angel Pons (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Kevin Chiu, Tarun Tuli, Eric Lai, Ricky Chang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 ) Change subject: mb/google/brya/var/lisbon: turn off thunderbolt ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68916/comment/f473b4c5_87be3d65 PS1, Line 7: turn off thunderbolt > Done It doesn't seem like much, but could you please change it? You can easily edit the commit message from Gerrit's Web UI, there's an "EDIT" button on the bottom right corner of the box showing the commit message: https://imgur.com/NQXe1hL.png https://review.coreboot.org/c/coreboot/+/68916/comment/90e845a9_9e1e173d PS1, Line 9: no support thunderbolt on lisbon > Done Eric's suggestion is a well-formed sentence, though. Could you please change it? -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:07:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: turn off thunderbolt
by Kevin Chiu (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Tarun Tuli, Eric Lai, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 ) Change subject: mb/google/brya/var/lisbon: turn off thunderbolt ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68916/comment/5baa2280_d49f078f PS1, Line 7: turn off thunderbolt > I suppose it's the same meaning, thanks. Done https://review.coreboot.org/c/coreboot/+/68916/comment/d1328c8f_8e9593f3 PS1, Line 9: no support thunderbolt on lisbon > the same, I suppose it's the same meaning, thanks. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: turn off thunderbolt
by Kevin Chiu (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Tarun Tuli, Eric Lai, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 ) Change subject: mb/google/brya/var/lisbon: turn off thunderbolt ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68916/comment/4a3ef4cd_3f8774c4 PS1, Line 7: turn off thunderbolt > Disable thunderbolt ports I suppose it's the same meaning, thanks. https://review.coreboot.org/c/coreboot/+/68916/comment/3375aa14_8343aa0c PS1, Line 9: no support thunderbolt on lisbon > Lisbon doesn't support thunderbolt. the same, I suppose it's the same meaning, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/68916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455 Gerrit-Change-Number: 68916 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sun, 06 Nov 2022 15:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "crossgcc: Upgrade IASL from 20211217 to 20220331"
by Elyes Haouas (Code Review) 06 Nov '22

06 Nov '22

Attention is currently required from: Martin L Roth, Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64103 ) Change subject: Revert "crossgcc: Upgrade IASL from 20211217 to 20220331" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Would you please give a shot to https://review.coreboot.org/c/coreboot/+/68929 ? -- To view, visit https://review.coreboot.org/c/coreboot/+/64103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c1b30585fdfab046a40d1721276d0fa40457a10 Gerrit-Change-Number: 64103 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 14:03:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022