Attention is currently required from: Maxim Polyakov, Reka Norman, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68983 )
Change subject: util: Add SPDX license headers to Makefiles
......................................................................
Patch Set 1:
(3 comments)
File util/bucts/Makefile:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161628):
https://review.coreboot.org/c/coreboot/+/68983/comment/cf07d932_cf7c13bb
PS1, Line 2: CC:=gcc
Do not use whitespace before Cc:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161628):
https://review.coreboot.org/c/coreboot/+/68983/comment/99f036c5_22f299d7
PS1, Line 2: CC:=gcc
Use a single space after Cc:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161628):
https://review.coreboot.org/c/coreboot/+/68983/comment/fcc34b98_dc025c25
PS1, Line 2: CC:=gcc
Unrecognized email address: '=gcc'
--
To view, visit https://review.coreboot.org/c/coreboot/+/68983
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cf35132df0bc23f7b6f78014ddd72d58ea2ab8a
Gerrit-Change-Number: 68983
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Sat, 29 Oct 2022 04:45:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68980 )
Change subject: drivers: Add SPDX license headers to Makefiles
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Note to future me.
for file in $(find . -name "Make*" | grep -iv "3rdparty\|vendorcode"); do if ! grep -q SPDX $file; then echo $file; sed -i '1i## SPDX-License-Identifier: GPL-2.0-only' $file ; fi; done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8442bc18ce228eca88a084660be84bcd1c5de928
Gerrit-Change-Number: 68980
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 29 Oct 2022 04:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment