coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: util/cbfstool: Add support for ARM64 UefiPayload
by Rex-BC Chen (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58055 to look at the new patch set (#2). Change subject: util/cbfstool: Add support for ARM64 UefiPayload ...................................................................... util/cbfstool: Add support for ARM64 UefiPayload To support ARM SystemReady. UEFI payload is supported on some ARM64 platforms, for example MT8195. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I4c0c6e263bd2f518a62ff9db44d72dd31086756a --- M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/coff.h 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/58055/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c0c6e263bd2f518a62ff9db44d72dd31086756a Gerrit-Change-Number: 58055 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Rex-BC Chen (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Hung-Te Lin, Martin Roth, Rex-BC Chen, Stefan Reinauer, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Stefan Reinauer, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58054 to look at the new patch set (#2). Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... payloads: Add UefiPayload support to ARM64 platforms Some ARM64 platforms, for example MT8195, is now able to compile and run EDK2 (UefiPayload). As a result, we should allow selecting PAYLOAD_TIANOCORE for ARM64 platforms. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 --- M payloads/external/tianocore/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58054/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Add Synaptics touchpad
by Felix Held (Code Review) 01 Oct '21

01 Oct '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58030 ) Change subject: mb/google/brya/var/kano: Add Synaptics touchpad ...................................................................... mb/google/brya/var/kano: Add Synaptics touchpad Add Synaptics touchpad for kano. BUG=None TEST=emerge-brya coreboot and check touchpad function work. Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: Iec43aaa9525309d2a0e3c9822038869786f5fe66 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58030 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index f8ac9ac..8802ab2 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -373,6 +373,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)" + register "generic.wake" = "GPE0_DW2_14" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end device ref gspi1 on chip drivers/spi/acpi -- To view, visit https://review.coreboot.org/c/coreboot/+/58030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec43aaa9525309d2a0e3c9822038869786f5fe66 Gerrit-Change-Number: 58030 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: sc7280: Add SHRM firmware support
by Julius Werner (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 ) Change subject: sc7280: Add SHRM firmware support ...................................................................... Patch Set 76: (1 comment) File src/soc/qualcomm/sc7280/Makefile.inc: https://review.coreboot.org/c/coreboot/+/49392/comment/27e6e23f_32ba473d PS76, Line 110: none Why no compression? -- To view, visit https://review.coreboot.org/c/coreboot/+/49392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762 Gerrit-Change-Number: 49392 Gerrit-PatchSet: 76 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Fri, 01 Oct 2021 01:34:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Add new vaviant quackingstick
by Sheng-Liang Pan (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Paul Menzel, Bob Moragues, Sheng-Liang Pan. Hello build bot (Jenkins), Julius Werner, Bob Moragues, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58033 to look at the new patch set (#3). Change subject: mb/google/trogdor: Add new vaviant quackingstick ...................................................................... mb/google/trogdor: Add new vaviant quackingstick New boards introduced to trogdor family. BUG=b:201263032 BRANCH=none TEST=make Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: I8299ddda14eb82103f17f8464a14992aa757afa6 --- M Documentation/security/vboot/list_vboot.md M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 3 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/58033/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/58033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8299ddda14eb82103f17f8464a14992aa757afa6 Gerrit-Change-Number: 58033 Gerrit-PatchSet: 3 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/tcss: Optimize Type-C DP flow
by Furquan Shaikh (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak, Derek Huang, Curtis Chen, Brandon Breitenstein. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57139 ) Change subject: soc/intel/common/tcss: Optimize Type-C DP flow ...................................................................... Patch Set 20: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50 Gerrit-Change-Number: 57139 Gerrit-PatchSet: 20 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Curtis Chen <curtis.chen(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 00:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Register USB-C mux operations
by Furquan Shaikh (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak, Derek Huang. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58061 ) Change subject: src/ec/google/chromeec: Register USB-C mux operations ...................................................................... Patch Set 1: (1 comment) File src/ec/google/chromeec/usbc_mux.c: https://review.coreboot.org/c/coreboot/+/58061/comment/dc6be424_7cee9619 PS1, Line 5: struct static const struct -- To view, visit https://review.coreboot.org/c/coreboot/+/58061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I576c9e4c6c82d6b4055b0a0a9a75c677d4b05220 Gerrit-Change-Number: 58061 Gerrit-PatchSet: 1 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 00:08:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info()
by Furquan Shaikh (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak, Derek Huang. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58060 ) Change subject: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8 Gerrit-Change-Number: 58060 Gerrit-PatchSet: 1 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 00:07:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Add new API for USB-C mux handling
by Furquan Shaikh (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak, Derek Huang. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58059 ) Change subject: src/ec/google/chromeec: Add new API for USB-C mux handling ...................................................................... Patch Set 1: (1 comment) File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/58059/comment/dd42900c_4e8c7a83 PS1, Line 1585: if (google_chromeec_usb_pd_get_info(port, &ufp, &dbg_acc, &active_cable, &dp_mode) < 0) { > line over 96 characters Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/58059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc27f23214c2d5b91334ae3efe248100329964ba Gerrit-Change-Number: 58059 Gerrit-PatchSet: 1 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 00:07:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Add APIs for USB-C DP ALT mode
by Furquan Shaikh (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak, Derek Huang, Brandon Breitenstein, Curtis Chen. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 ) Change subject: src/ec/google/chromeec: Add APIs for USB-C DP ALT mode ...................................................................... Patch Set 13: Code-Review+2 (1 comment) File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/57138/comment/0d999c2f_5b9a6907 PS13, Line 1675: !(mux_flags & USB_PD_MUX_HPD_LVL) || !(mux_flags & USB_PD_MUX_DP_ENABLED) nit: This can also be written as : ``` while ((mux_flags & hpd_asserted_mask) != hpd_asserted_mask)); ``` where, ``` hpd_asserted_mask = USB_PD_MUX_HPD_LVL | USB_PD_MUX_DP_ENABLED; ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/57138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3 Gerrit-Change-Number: 57138 Gerrit-PatchSet: 13 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 00:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021