Attention is currently required from: David Wu, Paul Menzel, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58165 )
Change subject: mb/google/brya/variants/brask: Init overridetree
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58165/comment/4694654d_03d80ad6
PS2, Line 11: bray0
> Ack
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/58165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30d26a47fe93736c63b578c9180b148ef73e8b9f
Gerrit-Change-Number: 58165
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 13 Oct 2021 21:21:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Bernardo Perez Priego.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58215 )
Change subject: util/cse_serger: Add command `create-cse-region`
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/cbfstool/cse_serger.c:
https://review.coreboot.org/c/coreboot/+/58215/comment/e4aacfa0_63cf7969
PS3, Line 720: if (i == 0) {
> It is a little weird. […]
Ah, I see... hmm, yeah I'd rather not have lines that don't end in semicolons
--
To view, visit https://review.coreboot.org/c/coreboot/+/58215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib087f5516e5beb6390831ef4e34b0b067d3fbc8b
Gerrit-Change-Number: 58215
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Comment-Date: Wed, 13 Oct 2021 21:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58306 )
Change subject: [WIP] soc/amd/common/block/uart: implement read_resource
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/58306/comment/a2e7cf24_7d52491d
PS1, Line 110: new_resource
Can you use `mmio_resource` instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ffddee3f5f4281aca98ddfcefa639dfb7a38dae
Gerrit-Change-Number: 58306
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 13 Oct 2021 21:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment