Joey Peng has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/58318 )
Change subject: /mb/google/brya/var/taeko: Add fw_config probe for GL9750 and RTS5232S
......................................................................
Removed reviewer Tim Wawrzynczak.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4353a094e2035ce94b5dd1a737e7e7009ad0614e
Gerrit-Change-Number: 58318
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58317 )
Change subject: soc/intel/common/acpi: Correct IPC sub command for reading LPM requirement
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/acpi/pep.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130373):
https://review.coreboot.org/c/coreboot/+/58317/comment/ecfa6082_b9fc74da
PS1, Line 51: PMC_IPC_CMD_SUBCMD_RD_PMC_REG, 0);
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/58317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58509f14f1e67472adda78e65c3a2e3ee9210765
Gerrit-Change-Number: 58317
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 05:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, YH Lin.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58297 )
Change subject: mb/google/brya/var/taeko: Include driver for GL9763E for eMMC boot disk
......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58297/comment/8fa571ee_4392bc05
PS2, Line 7: add support for GL9763E
> Include driver for GL9763E for eMMC boot disk
updated in latest patch.
https://review.coreboot.org/c/coreboot/+/58297/comment/b474390e_8aa07c76
PS2, Line 7: Taeko
> mb/google/brya/var/taeko
updated in latest patch.
https://review.coreboot.org/c/coreboot/+/58297/comment/1e9819ad_4fef56d3
PS2, Line 9: support
> Support
updated in latest patch.
https://review.coreboot.org/c/coreboot/+/58297/comment/fde6c0f0_28cab14d
PS2, Line 10:
> Did the schematics change, or was including the driver just forgotten when adding the variant?
Schematics change does not changed. The driver will be added started from EVT so we updated the variant.
https://review.coreboot.org/c/coreboot/+/58297/comment/49163b1e_5f469497
PS2, Line 13: TEST=enable DRIVERS_GENESYSLOGIC_GL9763E and check eMMC on taeko.
> What other ways are there to boot the device?
Hi Paul
Do you mean "taeko" has other boot device, like SSD? Or there's other way except for DRIVERS_GENESYSLOGIC_GL9763E can boot eMMC?
https://review.coreboot.org/c/coreboot/+/58297/comment/a0ef9631_fc9dbfd1
PS2, Line 16:
> remove this blank line (Cq-Depend must be in the footer)
updated in latest patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5db2b229ce1bbea54efe15f5288f13f8d4656899
Gerrit-Change-Number: 58297
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 03:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58313 )
Change subject: mb/google/guybrush/dewatt: update DRAM table
......................................................................
mb/google/guybrush/dewatt: update DRAM table
K4U6E3S4AB-MGCL
H54G46CYRBX267
MT53E1G32D2NP-046 WT:B
MT53E512M32D1NP-046 WT:B
BUG=b:203014978
BRANCH=guybrush
TEST=emerge-guybrush coreboot chromeos-bootimage
Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Change-Id: I31ec5b84b5ad2e8d0aedf41ceb56f9e5f7fa538a
---
M src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc
M src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt
M src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt
3 files changed, 20 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/58313/1
diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc b/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc
index 6751a42..069b2eb 100644
--- a/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc
+++ b/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc
@@ -1,5 +1,8 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# util/spd_tools/bin/part_id_gen CZN lp4x src/mainboard/google/guybrush/variants/dewatt/memory src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt
-SPD_SOURCES = placeholder
+SPD_SOURCES =
+SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AB-MGCL, H54G46CYRBX267, MT53E512M32D1NP-046 WT:B
+SPD_SOURCES += spd/lp4x/set-1/spd-3.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:B
diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt b/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt
index fa24790..5ce9e79 100644
--- a/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt
+++ b/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt
@@ -1 +1,10 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# util/spd_tools/bin/part_id_gen CZN lp4x src/mainboard/google/guybrush/variants/dewatt/memory src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt
+
DRAM Part Name ID to assign
+K4U6E3S4AB-MGCL 0 (0000)
+H54G46CYRBX267 0 (0000)
+MT53E1G32D2NP-046 WT:B 1 (0001)
+MT53E512M32D1NP-046 WT:B 0 (0000)
diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt b/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt
index 416b512..4b6ba22 100644
--- a/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt
+++ b/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt
@@ -1,11 +1,4 @@
-# This is a CSV file containing a list of memory parts used by this variant.
-# One part per line with an optional fixed ID in column 2.
-# Only include a fixed ID if it is required for legacy reasons!
-# Generated IDs are dependent on the order of parts in this file,
-# so new parts must always be added at the end of the file!
-#
-# Generate an updated Makefile.inc and dram_id.generated.txt by running the
-# part_id_gen tool from util/spd_tools.
-# See util/spd_tools/README.md for more details and instructions.
-
-# Part Name, Fixed ID (optional)
+K4U6E3S4AB-MGCL
+H54G46CYRBX267
+MT53E1G32D2NP-046 WT:B
+MT53E512M32D1NP-046 WT:B
--
To view, visit https://review.coreboot.org/c/coreboot/+/58313
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31ec5b84b5ad2e8d0aedf41ceb56f9e5f7fa538a
Gerrit-Change-Number: 58313
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Jakub Czapiga, Paul Fagerburg, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58242 )
Change subject: libpayload: Add unit-tests framework and first test case
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58242
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa94ee4dcdc3f74af830113813df0e8fb0b31e4f
Gerrit-Change-Number: 58242
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 02:17:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment