coreboot-gerrit June 2020

coreboot-gerrit@coreboot.org

1 participants
2826 discussions

Change in coreboot[master]: soc/amd/common: Complete ACPIMMIO GPIO bank separation
by Raul Rangel (Code Review) 25 Jun '20

25 Jun '20

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42690 ) Change subject: soc/amd/common: Complete ACPIMMIO GPIO bank separation ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/42690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c8c3f2028ca89dca5c7f0548fcd18e1045999d6 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 25 Jun 2020 18:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Use gpio_setbits32()
by Raul Rangel (Code Review) 25 Jun '20

25 Jun '20

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42688 ) Change subject: soc/amd/common: Use gpio_setbits32() ...................................................................... Patch Set 5: Code-Review+2 Ah, looks like we arrived at the same place :) -- To view, visit https://review.coreboot.org/c/coreboot/+/42688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4413d113dff550900348a44f71b949b7547a9cfc Gerrit-Change-Number: 42688 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 25 Jun 2020 17:37:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Refactor GPIO SCI/SMI interrupts
by Raul Rangel (Code Review) 25 Jun '20

25 Jun '20

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42687 ) Change subject: soc/amd/common: Refactor GPIO SCI/SMI interrupts ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/c/coreboot/+/42687/5/src/soc/amd/common/block/g… File src/soc/amd/common/block/gpio_banks/gpio.c: https://review.coreboot.org/c/coreboot/+/42687/5/src/soc/amd/common/block/g… PS5, Line 52: sci_trigger_regs Since you are deleting the SCI_TRIGGER_X macros, you add a comment saying 0 -> Low, 1 -> High for the polarity, and 0 -> Edge, 1 -> Level for the level field. https://review.coreboot.org/c/coreboot/+/42687/5/src/soc/amd/common/block/g… PS5, Line 55: level Can you name this trigger? Level makes me think Level high or Level low. Trigger makes me think edge or level. https://review.coreboot.org/c/coreboot/+/42687/5/src/soc/amd/common/block/g… PS5, Line 94: SMI_SCI_LEVEL I hate the name of these registers. https://review.coreboot.org/c/coreboot/+/42687/5/src/soc/amd/common/block/g… PS5, Line 190: { 0 }. { } is not a valid C standard construct, but a GCC extension. -- To view, visit https://review.coreboot.org/c/coreboot/+/42687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2c7cd70ab38d0d8e745b0a611b780d2b0b8dc5b Gerrit-Change-Number: 42687 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Thu, 25 Jun 2020 17:30:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Refactor GPIO_MASTER_SWITCH interrupt enable
by Raul Rangel (Code Review) 25 Jun '20

25 Jun '20

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42686 ) Change subject: soc/amd/common: Refactor GPIO_MASTER_SWITCH interrupt enable ...................................................................... Patch Set 5: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/42686/5/src/soc/amd/common/block/g… File src/soc/amd/common/block/gpio_banks/gpio.c: https://review.coreboot.org/c/coreboot/+/42686/5/src/soc/amd/common/block/g… PS5, Line 110: master_reg Isn't it a little hacky to proxy the register address through as a GPIO offset? -- To view, visit https://review.coreboot.org/c/coreboot/+/42686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754a2f6bbee12d637f8c99a9d330ab0ac8187247 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 25 Jun 2020 17:13:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: fix add psp_verstage
by Martin Roth (Code Review) 25 Jun '20

25 Jun '20

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42764 ) Change subject: fix add psp_verstage ...................................................................... fix add psp_verstage Change-Id: I26efff4ee44deaf638f5c10fc6f9283f579bb705 --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42764/1 diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 1bf2bd9..d93ebd5 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -246,6 +246,7 @@ PSP_UCODE_FILE2=$(FIRMWARE_LOCATE)/UcodePatch_PCO_B0.bin PSP_UCODE_FILE3=$(FIRMWARE_LOCATE)/UcodePatch_RV2_A0.bin +ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y) # type = 0x6B - PSP Shared memory location ifneq ($(CONFIG_PSP_SHAREDMEM_SIZE),0x0) PSP_SHAREDMEM_SIZE=$(CONFIG_PSP_SHAREDMEM_SIZE) @@ -254,9 +255,8 @@ endif # type = 0x52 - PSP Bootloader Userspace Application (verstage) -ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y) PSP_VERSTAGE_FILE=$(obj)/psp_verstage.bin -endif +endif # CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK # type = 0xb - See #55758 (NDA) for bit definitions. PSP_SOFTFUSE_BITS += 28 -- To view, visit https://review.coreboot.org/c/coreboot/+/42764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26efff4ee44deaf638f5c10fc6f9283f579bb705 Gerrit-Change-Number: 42764 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 2

Change in coreboot[master]: mb/amd/mandolin: Drop empty help text
by Patrick Georgi (Code Review) 25 Jun '20

25 Jun '20

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42775 ) Change subject: mb/amd/mandolin: Drop empty help text ...................................................................... mb/amd/mandolin: Drop empty help text kconfig complains. Change-Id: I281e4faa53cad5677864305feb9162b598ae483e Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/42775/1 diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 5c5a2b6..b32f5df 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -76,7 +76,6 @@ config MANDOLIN_IOMUX_USE_LPC bool "LPC signals" - help config MANDOLIN_IOMUX_USE_EMMC bool "eMMC signals" -- To view, visit https://review.coreboot.org/c/coreboot/+/42775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I281e4faa53cad5677864305feb9162b598ae483e Gerrit-Change-Number: 42775 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: util/abuild: Only update submodules once
by Patrick Georgi (Code Review) 25 Jun '20

25 Jun '20

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42774 ) Change subject: util/abuild: Only update submodules once ...................................................................... util/abuild: Only update submodules once Without this, each build will try to update the submodules. Not necessarily a problem but git locks repos, creating spurious error messages. Change-Id: Iba20677d4b5f9365c92f7ed247ca56acb7d33b27 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/abuild/abuild 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/42774/1 diff --git a/util/abuild/abuild b/util/abuild/abuild index 022567d..6e14765 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -796,8 +796,11 @@ echo | xargs -P ${cpus:-0} -n 1 echo 2>/dev/null >/dev/null && USE_XARGS=1 fi +git submodule update --checkout --init + if [ "$USE_XARGS" = "0" ]; then test "$MAKEFLAGS" == "" && test "$cpus" != "" && export MAKEFLAGS="-j $cpus" +export MAKEFLAGS="$MAKEFLAGS UPDATED_SUBMODULES=1" # no need to re-download build_targets() { local targets=${*-$(get_mainboards)} -- To view, visit https://review.coreboot.org/c/coreboot/+/42774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba20677d4b5f9365c92f7ed247ca56acb7d33b27 Gerrit-Change-Number: 42774 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100
by Marshall Dawson (Code Review) 25 Jun '20

25 Jun '20

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42708 ) Change subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100 ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/i… File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h: https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/i… PS4, Line 36: /* Family 14h or before */ It's 100% of the discrete controller hubs, plus Kabini (Family 16h Models 00h-0Fh). Mullins (Family 16h Models 30h-3Fh) had the newer GPIO banks. And some of those discrete FCHs were also paired with Family 15h APUs. So, I'm not sure how complex you want the comment to be. Maybe something like "All discrete FCH and f16kb". -- To view, visit https://review.coreboot.org/c/coreboot/+/42708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29fbc82fffc69b864adb4ddbda1425db98e2e48a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 25 Jun 2020 16:45:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100
by Raul Rangel (Code Review) 25 Jun '20

25 Jun '20

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42708 ) Change subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/42708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29fbc82fffc69b864adb4ddbda1425db98e2e48a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 25 Jun 2020 16:30:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "soc/amd/common/block/acpimmio: Update acpimmio for psp_verstage"
by Raul Rangel (Code Review) 25 Jun '20

25 Jun '20

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42486 ) Change subject: Revert "soc/amd/common/block/acpimmio: Update acpimmio for psp_verstage" ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/42486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d632f52745bc6cd3c3dbddb1ea5ff9ba962c2e8 Gerrit-Change-Number: 42486 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 25 Jun 2020 16:18:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2020