Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35718 )
Change subject: gma bxt: Implement CDClk switching
......................................................................
Patch Set 2:
Needs update to `Frequency_Type` or restructuring, lower end
would have to be 90% of the current 19.2MHz.
Or, alternatively, let `CDClk_Range` equal `Frequency_Type`
on generations that support full-speed dot clocks.
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I7bccbce0625a9893e2dd5c06fd1475a44987989d
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Sun, 29 Sep 2019 20:25:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35711 )
Change subject: gma: Give GM45 its own designation (separate from G45)
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I99bbd0582a03a9e2806ef2ebf63e466ec40133b3
Gerrit-Change-Number: 35711
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Sun, 29 Sep 2019 19:40:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello Arthur Heymans, Matt DeVillier, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/35719
to look at the new patch set (#2).
Change subject: gma: Automatically update CDClk and dot clocks
......................................................................
gma: Automatically update CDClk and dot clocks
Dot clocks should be limited, depending on CDClk. This comes with a
caveat: if a display only works at a specific refresh rate, we will
likely fail without knowing. It seems to be better, though, to try
at least. We can implement a config switch controlling this beha-
viour, later, if needed.
If we can raise / lower CDClk with a given set of dot clocks, we
have to disable all pipes first, then switch CDClk, and finally
enable all pipes with their new configuration.
Change-Id: I375f2bd37c921cd5ed4b0094247df5a34a087188
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M common/hw-gfx-gma.adb
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/19/35719/2
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35719
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I375f2bd37c921cd5ed4b0094247df5a34a087188
Gerrit-Change-Number: 35719
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30117/21/src/arch/x86/include/arch…
File src/arch/x86/include/arch/registers.h:
https://review.coreboot.org/c/coreboot/+/30117/21/src/arch/x86/include/arch…
PS21, Line 44: #define QUAD_DOWNTO8(A) \
macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/30117/21/src/arch/x86/include/arch…
PS21, Line 50: #define QUAD_DOWNTO16(A) \
macros should not use a trailing semicolon
--
To view, visit https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 21
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 29 Sep 2019 17:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35680/5/util/pgtblgen/pgtblgen.c
File util/pgtblgen/pgtblgen.c:
https://review.coreboot.org/c/coreboot/+/35680/5/util/pgtblgen/pgtblgen.c@28
PS5, Line 28: printf("usage: %s -b <addr> -a <arch> -o <file>\n", argv[0]);
Prefer using '"%s...", __func__' to using 'usage', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/35680/5/util/pgtblgen/pgtblgen.c@1…
PS5, Line 145: FILE *fd = fopen(filename, "wb");
need consistent spacing around '*' (ctx:WxV)
--
To view, visit https://review.coreboot.org/c/coreboot/+/35680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Gerrit-Change-Number: 35680
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com>
Gerrit-Reviewer: Gerd Hoffmann <kraxel(a)redhat.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 29 Sep 2019 17:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Kyösti Mälkki, Aaron Durbin, Alexandru Gagniuc, ron minnich, Gerd Hoffmann, Lee Leahy, Stefan Reinauer, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35680
to look at the new patch set (#5).
Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................
cpu/qemu-x86: Add x86_64 bootblock support
Add support for x86_64 bootblock on qemu.
Introduce a new approach to long mode support. The previous patch set
generated page tables at runtime and placed them in heap. The new
approach places the page tables in memory mapped ROM.
Introduce a new tool called pgtblgen that creates x86 long mode compatible
page tables and writes those to a file. The file is included into the CBFS
and placed at a predefined offset.
Add assembly code to load the page tables, based on a Kconfig symbol and
enter long in bootblock.
The code can be easily ported to real hardware bootblock.
Tested on qemu q35.
Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
M Documentation/arch/x86/index.md
M Makefile.inc
M src/arch/x86/Kconfig
M src/arch/x86/bootblock_crt0.S
M src/cpu/qemu-x86/cache_as_ram_bootblock.S
A src/cpu/x86/64bit/entry64.inc
A util/pgtblgen/Makefile.inc
A util/pgtblgen/description.md
A util/pgtblgen/pgtblgen.c
9 files changed, 287 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/35680/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/35680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Gerrit-Change-Number: 35680
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com>
Gerrit-Reviewer: Gerd Hoffmann <kraxel(a)redhat.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30117/20/src/arch/x86/include/arch…
File src/arch/x86/include/arch/registers.h:
https://review.coreboot.org/c/coreboot/+/30117/20/src/arch/x86/include/arch…
PS20, Line 44: #define QUAD_DOWNTO8(A) \
macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/30117/20/src/arch/x86/include/arch…
PS20, Line 50: #define QUAD_DOWNTO16(A) \
macros should not use a trailing semicolon
--
To view, visit https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 20
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 29 Sep 2019 17:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment