coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mb/google/poppy/variants/nami: Prevent leakage with touchscreen on Pa...
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27177 ) Change subject: mb/google/poppy/variants/nami: Prevent leakage with touchscreen on Pantheon ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75263/ : SUCCESS -- To view, visit https://review.coreboot.org/27177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af Gerrit-Change-Number: 27177 Gerrit-PatchSet: 5 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Jun 2018 03:02:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27218 ) Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… File src/southbridge/intel/bd82x6x/Kconfig: https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… PS1, Line 69: config HAVE_IFD_BIN : def_bool n : : config BUILD_WITH_FAKE_IFD : def_bool n > I guess to reason to include a fake ifd to make flashrom happy ? Why change the default ? It needs a downstream flashrom patch that was abandoned some years ago. So I wouldn't mind if we just remove all traces of ifdfake. But you are probably right, it doesn't belong into this patch. -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 16:27:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Patrick Rudolph (Code Review) 24 Jun '18

24 Jun '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27218 ) Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… File src/southbridge/intel/bd82x6x/Kconfig: https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… PS1, Line 69: config HAVE_IFD_BIN : def_bool n : : config BUILD_WITH_FAKE_IFD : def_bool n > Jenkins already answered that... and I guess it's supposed […] I guess to reason to include a fake ifd to make flashrom happy ? Why change the default ? -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 16:17:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27218 ) Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… File src/southbridge/intel/bd82x6x/Kconfig: https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… PS1, Line 69: config HAVE_IFD_BIN : def_bool n : : config BUILD_WITH_FAKE_IFD : def_bool n > Will it still compile without blob and without using fake ifd? Jenkins already answered that... and I guess it's supposed to work. The `add_intel_firmware:` target should simply be ignored and sb/intel/common/firmware/Makefile.inc would become a no-op. Then it's just like any normal coreboot build. -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 15:30:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Patrick Rudolph (Code Review) 24 Jun '18

24 Jun '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27218 ) Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… File src/southbridge/intel/bd82x6x/Kconfig: https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… PS1, Line 69: config HAVE_IFD_BIN : def_bool n : : config BUILD_WITH_FAKE_IFD : def_bool n > Can drop these they should already default to n implicitly. Will it still compile without blob and without using fake ifd? -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 15:14:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27218 ) Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... Patch Set 1: (1 comment) HAVE_IFD_BIN is about having the file in the repo. We have the file for the boards that currently don't override the default. So they need an override now. I would prefer a single commit that inverts the chipset default, adds a `default y` override (or even better `select HAVE_IFD_BIN`) for the affected boards that currently don't have an override and removes all the `default n` board overrides. https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… File src/southbridge/intel/bd82x6x/Kconfig: https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconf… PS1, Line 69: config HAVE_IFD_BIN : def_bool n : : config BUILD_WITH_FAKE_IFD : def_bool n Can drop these they should already default to n implicitly. -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 14:11:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by build bot (Jenkins) (Code Review) 24 Jun '18

24 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27218 ) Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29319/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75260/ : SUCCESS -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 12:23:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
by Angel Pons (Code Review) 24 Jun '18

24 Jun '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/27218 Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ...................................................................... southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default Since only a handful of boards have descriptor blobs in the tree, it makes little sense to leave it enabled by default. This would require less mainboard-specific Kconfig overrides. If this receives positive feedback, every affected motherboard will be updated in a later patch set. Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/southbridge/intel/bd82x6x/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/27218/1 diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig index 9a70bf2..53ad840 100644 --- a/src/southbridge/intel/bd82x6x/Kconfig +++ b/src/southbridge/intel/bd82x6x/Kconfig @@ -67,10 +67,10 @@ default 0x80 config HAVE_IFD_BIN - def_bool y + def_bool n config BUILD_WITH_FAKE_IFD - def_bool !HAVE_IFD_BIN + def_bool n endif -- To view, visit https://review.coreboot.org/27218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: mb/gigabyte/ga-{h61m-s2pv, b75m-d3h, b75m-d3v}: Clean up CMOS files
by build bot (Jenkins) (Code Review) 24 Jun '18

24 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27217 ) Change subject: mb/gigabyte/ga-{h61m-s2pv,b75m-d3h,b75m-d3v}: Clean up CMOS files ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75259/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29318/ : SUCCESS -- To view, visit https://review.coreboot.org/27217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e904f447809231806a786e39ed638f21e1bc5a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 10:44:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018