coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: cpu/intel/haswell: Use the common intel romstage_main function
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26835 ) Change subject: cpu/intel/haswell: Use the common intel romstage_main function ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74255/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28368/ : SUCCESS -- To view, visit https://review.coreboot.org/26835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6453c40bf4ebe4695684c1bd3a403d6def82814f Gerrit-Change-Number: 26835 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 07:54:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: {src, util}: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26857 ) Change subject: {src,util}: Use NULL instead of 0 for pointer ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74254/ : SUCCESS -- To view, visit https://review.coreboot.org/26857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Gerrit-Change-Number: 26857 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 07:52:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/haswell: Use the common intel romstage_main function
by Arthur Heymans (Code Review) 05 Jun '18

05 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26835 to look at the new patch set (#2). Change subject: cpu/intel/haswell: Use the common intel romstage_main function ...................................................................... cpu/intel/haswell: Use the common intel romstage_main function Tested on Google peppy (Acer C720). Change-Id: I6453c40bf4ebe4695684c1bd3a403d6def82814f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/haswell/Makefile.inc M src/cpu/intel/haswell/haswell.h M src/cpu/intel/haswell/romstage.c M src/mainboard/google/beltino/romstage.c M src/mainboard/google/slippy/romstage.c M src/mainboard/intel/baskingridge/romstage.c M src/northbridge/intel/haswell/Kconfig 7 files changed, 6 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/26835/2 -- To view, visit https://review.coreboot.org/26835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6453c40bf4ebe4695684c1bd3a403d6def82814f Gerrit-Change-Number: 26835 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/kukui: Add MediaTek MT8183 reference board
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26722 ) Change subject: google/kukui: Add MediaTek MT8183 reference board ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74253/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28367/ : SUCCESS -- To view, visit https://review.coreboot.org/26722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08644892d34925574f791b000b0035d5afad7022 Gerrit-Change-Number: 26722 Gerrit-PatchSet: 14 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 07:46:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL instead of 0 for pointer
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26857 ) Change subject: src: Use NULL instead of 0 for pointer ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74252/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28366/ : SUCCESS -- To view, visit https://review.coreboot.org/26857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Gerrit-Change-Number: 26857 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 07:42:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Use NULL enstead of 0 for pointer
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

1 0

Change in coreboot[master]: src: Use NULL enstead of 0 for pointer
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26857 ) Change subject: src: Use NULL enstead of 0 for pointer ...................................................................... Patch Set 2: (7 comments) https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4.c File util/cbfstool/lz4/lib/lz4.c: https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4.c@799 PS2, Line 799: *srcSizePtr = NULL; please, no spaces at the start of a line https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c File util/cbfstool/lz4/lib/lz4frame.c: https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@937 PS2, Line 937: *srcSizePtr = NULL; code indent should use tabs where possible https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@937 PS2, Line 937: *srcSizePtr = NULL; please, no spaces at the start of a line https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@10… PS2, Line 1064: *srcSizePtr = NULL; please, no spaces at the start of a line https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@10… PS2, Line 1065: *dstSizePtr = NULL; please, no spaces at the start of a line https://review.coreboot.org/#/c/26857/2/util/cbfstool/lzma/C/LzmaDec.c File util/cbfstool/lzma/C/LzmaDec.c: https://review.coreboot.org/#/c/26857/2/util/cbfstool/lzma/C/LzmaDec.c@838 PS2, Line 838: *srcLen = *destLen = NULL; please, no spaces at the start of a line https://review.coreboot.org/#/c/26857/2/util/cbfstool/lzma/C/LzmaDec.c@971 PS2, Line 971: *srcLen = *destLen = NULL; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/26857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Gerrit-Change-Number: 26857 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 07:14:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src: Use NULL enstead of 0 for pointer
by Elyes HAOUAS (Code Review) 05 Jun '18

05 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26857 to look at the new patch set (#2). Change subject: src: Use NULL enstead of 0 for pointer ...................................................................... src: Use NULL enstead of 0 for pointer Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/intel/fsp1_0/hob.c M src/lib/libgcov.c M src/mainboard/google/link/i915.c M src/northbridge/amd/lx/northbridgeinit.c M util/cbfstool/lz4/lib/lz4.c M util/cbfstool/lz4/lib/lz4frame.c M util/cbfstool/lzma/C/LzmaDec.c M util/kconfig/lxdialog/util.c M util/kconfig/nconf.c M util/kconfig/qconf.h M util/kconfig/regex.c M util/sconfig/main.c M util/vgabios/testbios.c 13 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/26857/2 -- To view, visit https://review.coreboot.org/26857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Gerrit-Change-Number: 26857 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/sconfig/main.c: Use NULL for 'struct device *' enstead of = 0
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26857 ) Change subject: util/sconfig/main.c: Use NULL for 'struct device *' enstead of = 0 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74250/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28364/ : SUCCESS -- To view, visit https://review.coreboot.org/26857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Gerrit-Change-Number: 26857 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 06:48:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig/main.c: Use NULL for 'struct device *' enstead of = 0
by Elyes HAOUAS (Code Review) 05 Jun '18

05 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26857 Change subject: util/sconfig/main.c: Use NULL for 'struct device *' enstead of = 0 ...................................................................... util/sconfig/main.c: Use NULL for 'struct device *' enstead of = 0 Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/sconfig/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/26857/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 2e34d85..85c1f1d 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -82,7 +82,7 @@ void fold_in(struct device *parent) { struct device *child = parent->children; - struct device *latest = 0; + struct device *latest = NULL; while (child != latest) { if (child->children) { if (!latest) -- To view, visit https://review.coreboot.org/26857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92 Gerrit-Change-Number: 26857 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018