coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: Add rev 2 gpio changes
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23391 ) Change subject: mainboard/google/zoombini/variants/meowth: Add rev 2 gpio changes ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21381/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66783/ : SUCCESS -- To view, visit https://review.coreboot.org/23391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e6d049faaa0a70b40ceb47aaf81a81d820dd4c1 Gerrit-Change-Number: 23391 Gerrit-PatchSet: 5 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 14:26:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variant/meowth: enable FCAM_PWR_EN
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23503 ) Change subject: mainboard/google/zoombini/variant/meowth: enable FCAM_PWR_EN ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66781/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21379/ : SUCCESS -- To view, visit https://review.coreboot.org/23503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f31b19dfef5fe386b485dd675f0ff981288acf4 Gerrit-Change-Number: 23503 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 14:16:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variant/meowth: enable FCAM_PWR_EN
by Nick Vaccaro (Code Review) 30 Jan '18

30 Jan '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/23503 Change subject: mainboard/google/zoombini/variant/meowth: enable FCAM_PWR_EN ...................................................................... mainboard/google/zoombini/variant/meowth: enable FCAM_PWR_EN Turn on power for front camera at startup in coreboot (needs to be set for factory scan). BUG=b:69011806 BRANCH=master TEST=none Change-Id: I2f31b19dfef5fe386b485dd675f0ff981288acf4 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/zoombini/variants/meowth/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/23503/1 diff --git a/src/mainboard/google/zoombini/variants/meowth/gpio.c b/src/mainboard/google/zoombini/variants/meowth/gpio.c index cd9b9e3..8fff84f 100644 --- a/src/mainboard/google/zoombini/variants/meowth/gpio.c +++ b/src/mainboard/google/zoombini/variants/meowth/gpio.c @@ -124,7 +124,7 @@ /* ISH_I2C1_SDA */ PAD_CFG_GPO(GPP_D7, 1, DEEP), /* FCAM_RST_L */ /* ISH_I2C1_SCL */ PAD_NC(GPP_D8, NONE), /* ISH_SPI_CS# */ PAD_CFG_GPO(GPP_D9, 1, DEEP), /* PP3300_WLAN_EN */ -/* ISH_SPI_CLK */ PAD_CFG_GPO(GPP_D10, 0, DEEP), /* FCAM_PWR_EN */ +/* ISH_SPI_CLK */ PAD_CFG_GPO(GPP_D10, 1, DEEP), /* FCAM_PWR_EN */ /* ISH_SPI_MISO */ PAD_NC(GPP_D11, NONE), /* ISH_SPI_MOSI */ PAD_CFG_GPI(GPP_D12, NONE, DEEP), /* GPP_D12_STRAP */ /* ISH_UART0_RXD */ PAD_NC(GPP_D13, NONE), /* ISH_UART_RX */ -- To view, visit https://review.coreboot.org/23503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2f31b19dfef5fe386b485dd675f0ff981288acf4 Gerrit-Change-Number: 23503 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: [WIP, NOTFORMERGE]nb/intel/i945: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23496 ) Change subject: [WIP,NOTFORMERGE]nb/intel/i945: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66780/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/21378/ : SUCCESS -- To view, visit https://review.coreboot.org/23496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a301c47f058b119f692ee1cff2e43414281a861 Gerrit-Change-Number: 23496 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 12:34:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP, NOTFORMERGE]nb/intel/i945: Use C_ENVIRONMENT_BOOTBLOCK
by Arthur Heymans (Code Review) 30 Jan '18

30 Jan '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23496 to look at the new patch set (#2). Change subject: [WIP,NOTFORMERGE]nb/intel/i945: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... [WIP,NOTFORMERGE]nb/intel/i945: Use C_ENVIRONMENT_BOOTBLOCK When the rom is cached in bootblock, ramstage currently fails to run properly. If no mtrr covers the ROM it boots fine, but ofc romstage will be terribly slow... Change-Id: I4a301c47f058b119f692ee1cff2e43414281a861 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/car/Makefile.inc A src/cpu/intel/car/bootblock.c M src/cpu/intel/car/cache_as_ram.S M src/cpu/intel/car/romstage.c M src/cpu/intel/car/teardown_car.S M src/cpu/intel/common/Kconfig M src/cpu/intel/common/Makefile.inc A src/cpu/intel/common/util.c A src/cpu/intel/common/util.h M src/cpu/intel/socket_441/Kconfig M src/mainboard/intel/d945gclf/Makefile.inc A src/mainboard/intel/d945gclf/bootblock.c M src/mainboard/intel/d945gclf/romstage.c M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/i945/Makefile.inc M src/northbridge/intel/i945/bootblock.c M src/northbridge/intel/i945/ram_calc.c M src/soc/intel/common/block/cpu/car/cache_as_ram.S M src/superio/smsc/lpc47m15x/Makefile.inc 19 files changed, 426 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/23496/2 -- To view, visit https://review.coreboot.org/23496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4a301c47f058b119f692ee1cff2e43414281a861 Gerrit-Change-Number: 23496 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/skylake: Set PsysPmax value
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23268 ) Change subject: soc/intel/skylake: Set PsysPmax value ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21377/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66779/ : SUCCESS -- To view, visit https://review.coreboot.org/23268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f2e2917a8eb9ce3bb69d9c15899d4c7c5b2883 Gerrit-Change-Number: 23268 Gerrit-PatchSet: 7 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 11:03:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [RFC]drivers/intel/gma: Add common devicetree structure
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23502 ) Change subject: [RFC]drivers/intel/gma: Add common devicetree structure ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21376/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66778/ : SUCCESS -- To view, visit https://review.coreboot.org/23502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29c5090a21537f823d14bda2b1d5f03dd8d58c1c Gerrit-Change-Number: 23502 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 09:36:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [RFC]drivers/intel/gma: Add common devicetree structure
by Patrick Rudolph (Code Review) 30 Jan '18

30 Jan '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/23502 Change subject: [RFC]drivers/intel/gma: Add common devicetree structure ...................................................................... [RFC]drivers/intel/gma: Add common devicetree structure Add a platform independend structure to hold all required GPU related information. Every field has a clear description and usage. Instead of using the northbridge device, the new field will be attached to the GMA device. To be used on all Intel platforms. Change-Id: I29c5090a21537f823d14bda2b1d5f03dd8d58c1c Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- A src/drivers/intel/gma/chip.h 1 file changed, 71 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/23502/1 diff --git a/src/drivers/intel/gma/chip.h b/src/drivers/intel/gma/chip.h new file mode 100644 index 0000000..b05ebe5 --- /dev/null +++ b/src/drivers/intel/gma/chip.h @@ -0,0 +1,71 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2014 Vladimir Serbinenko <phcoder(a)gmail.com> + * Copyright (C) 2012 Duncan Laurie <dlaurie(a)google.com> + * Copyright (C) 2012 Stefan Reinauer <reinauer(a)google.com> + * Copyright (C) 2018 Patrick Rudolph <siro(a)das-labor.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _INTEL_GMA_CHIP_H_ +#define _INTEL_GMA_CHIP_H_ + +struct drivers_intel_gma_config { + /* Optional: Non default register for SWSMI / SWSCI */ + u8 reg_swsmisci; + /* Enable spread spectrum control */ + u8 use_spread_spectrum_clock; + /* Use 270 Mhz link frequency */ + u8 link_frequency_270_mhz; + /* Enable CRT connector */ + u8 use_crt; + /* Enable LVDS connector */ + u8 use_lvds; + + /* + * Digital Port Hotplug Enable: + * 0x04 = Enabled, 2ms short pulse + * 0x05 = Enabled, 4.5ms short pulse + * 0x06 = Enabled, 6ms short pulse + * 0x07 = Enabled, 100ms short pulse + */ + u8 dp_b_hotplug; /* Digital Port B Hotplug Config */ + u8 dp_c_hotplug; /* Digital Port C Hotplug Config */ + u8 dp_d_hotplug; /* Digital Port D Hotplug Config */ + + u8 panel_port_select; /* 0=LVDS 1=DP_B 2=DP_C 3=DP_D */ + u8 panel_power_cycle_delay; /* T4 time sequence */ + u16 panel_power_up_delay; /* T1+T2 time sequence */ + u16 panel_power_down_delay; /* T3 time sequence */ + u16 panel_power_backlight_on_delay; /* T5 time sequence */ + u16 panel_power_backlight_off_delay; /* Tx time sequence */ + + u32 cpu_backlight; /* CPU Backlight PWM value */ + u32 pch_backlight; /* PCH Backlight PWM value */ + + /* Hot-pluggable connectors */ + u32 hotplug; + + /* + * Default panel brightness level in percent. + * If zero the value is ignored. + */ + u8 duty_cycle; + + /* Number of devices attached to display adapter. Up to 5 */ + u8 ndid; + /* Devices attached to display adapter */ + u32 did[5]; +}; + + +#endif /* _INTEL_GMA_CHIP_H_ */ -- To view, visit https://review.coreboot.org/23502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I29c5090a21537f823d14bda2b1d5f03dd8d58c1c Gerrit-Change-Number: 23502 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Add support to display FSP version info Hob
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23386 ) Change subject: drivers/intel/fsp2_0: Add support to display FSP version info Hob ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21374/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66776/ : SUCCESS -- To view, visit https://review.coreboot.org/23386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib749e49a9f263d85947b60d4c445faf8c37f5931 Gerrit-Change-Number: 23386 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 07:06:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: CannonaLake make use of FVI information
by build bot (Jenkins) (Code Review) 30 Jan '18

30 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23387 ) Change subject: soc/intel/cannonlake: CannonaLake make use of FVI information ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21375/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66777/ : SUCCESS -- To view, visit https://review.coreboot.org/23387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfcac0002998e8a6594bb6dfc68b2577f62ddbff Gerrit-Change-Number: 23387 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 07:02:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018