coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: autoport/bd82x6x.go: Improve gpio.c generation
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19508 ) Change subject: autoport/bd82x6x.go: Improve gpio.c generation ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53002/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/8846/ : SUCCESS -- To view, visit https://review.coreboot.org/19508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83382d38a4a3b7ed11b8e7077cc5fbe154e261a7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: Add GPL boilerplate header to not empty .c files
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19510 to look at the new patch set (#3). Change subject: autoport: Add GPL boilerplate header to not empty .c files ...................................................................... autoport: Add GPL boilerplate header to not empty .c files The idea behind this not to enforce a license on autogenerated code but is simply out of convenience in the case one wants to make the result public (in which case it needs to have these license headers). Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/autoport/azalia.go M util/autoport/bd82x6x.go M util/autoport/ec_lenovo.go M util/autoport/main.go 4 files changed, 27 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/19510/3 -- To view, visit https://review.coreboot.org/19510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: autoport/bd82x6x.go: Improve gpio.c generation
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19508 to look at the new patch set (#3). Change subject: autoport/bd82x6x.go: Improve gpio.c generation ...................................................................... autoport/bd82x6x.go: Improve gpio.c generation This generates better gpio.c files where structs are initialised as static to be able to drop some entries since those would be initialised as 0. This makes these files less cluttered since only relevant things are shown: * GPIO direction, level, invert, blink depend on GPIO mode * GPIO level is read only on input * GPIO invert is only valid on input * only show when GPIO are inverted, blinking, reset by RSMRST# Change-Id: I83382d38a4a3b7ed11b8e7077cc5fbe154e261a7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/autoport/bd82x6x.go 1 file changed, 38 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/19508/3 -- To view, visit https://review.coreboot.org/19508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83382d38a4a3b7ed11b8e7077cc5fbe154e261a7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: autoport: Add GPL boilerplate header to not empty .c files
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19510 ) Change subject: autoport: Add GPL boilerplate header to not empty .c files ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53001/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8845/ : SUCCESS -- To view, visit https://review.coreboot.org/19510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport/bd82x6x.go: Improve gpio.c generation
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19508 to look at the new patch set (#2). Change subject: autoport/bd82x6x.go: Improve gpio.c generation ...................................................................... autoport/bd82x6x.go: Improve gpio.c generation This generates better gpio.c files where structs are initialised as static to be able to drop some entries since those would be initialised as 0. This makes these files less cluttered since only relevant things are shown: * GPIO direction, level, invert, blink depend on GPIO mode * GPIO level is read only on input * GPIO invert is only valid on input * only show when GPIO are inverted, blinking, reset by RSMRST# Change-Id: I83382d38a4a3b7ed11b8e7077cc5fbe154e261a7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/autoport/bd82x6x.go 1 file changed, 38 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/19508/2 -- To view, visit https://review.coreboot.org/19508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83382d38a4a3b7ed11b8e7077cc5fbe154e261a7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: sb/intel/common/firmware: Keep CHECK_ME disabled by default
by Nicola Corna (Code Review) 01 May '17

01 May '17

Nicola Corna has posted comments on this change. ( https://review.coreboot.org/19257 ) Change subject: sb/intel/common/firmware: Keep CHECK_ME disabled by default ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19257/1//COMMIT_MSG Commit Message: PS1, Line 9: Keeping CHECK_ME unset by default. > IMO this option is only useful if people are messing with their ME binary. with the -c flag the ME binary is opened in read-only mode, and it just checks the presence of the fundamental parts of the ME image https://github.com/corna/me_cleaner/blob/master/me_cleaner.py#L310 The checks are performed by the tool designed for the deblobbing because it's the only tool able to look inside the ME images, and most of the checks are in common. If this is raising suspects, I can split me_cleaner in two. -- To view, visit https://review.coreboot.org/19257 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3186498c8da307b686c06c3828e24acbc7f2d17 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: pcengines/apu1: Support TPM modules on the LPC connector
by Patrick Rudolph (Code Review) 01 May '17

01 May '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/12796 ) Change subject: pcengines/apu1: Support TPM modules on the LPC connector ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/12796 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie732228471f6c40d77e17cbed34726961b1fcddd Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: Add GPL boilerplate header to not empty .c files
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19510 ) Change subject: autoport: Add GPL boilerplate header to not empty .c files ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53000/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8844/ : SUCCESS -- To view, visit https://review.coreboot.org/19510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: Add GPL boilerplate header to not empty .c files
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19510 ) Change subject: autoport: Add GPL boilerplate header to not empty .c files ...................................................................... Patch Set 1: IANAL so no idea about copyright status of machine generated code, but it's convenient not to have to add boilerplate licence headers to c files manually. -- To view, visit https://review.coreboot.org/19510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: Add GPL boilerplate header to not empty .c files
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19510 ) Change subject: autoport: Add GPL boilerplate header to not empty .c files ...................................................................... autoport: Add GPL boilerplate header to not empty .c files The idea behind this not to enforce a license on autogenerated code but is simply out of convenience in the case one wants to make the result public (in which case it needs to have these license headers). Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/autoport/azalia.go M util/autoport/bd82x6x.go M util/autoport/ec_lenovo.go M util/autoport/main.go 4 files changed, 27 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/19510/1 diff --git a/util/autoport/azalia.go b/util/autoport/azalia.go index 2ee60d7..c525189 100644 --- a/util/autoport/azalia.go +++ b/util/autoport/azalia.go @@ -12,6 +12,7 @@ az := Create(ctx, "hda_verb.c") defer az.Close() + Add_gpl(az) az.WriteString( `#include <device/azalia_device.h> diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 9a41223..7dce7e6 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -43,6 +43,7 @@ AddROMStageFile("gpio.c", "") + Add_gpl(gpio) gpio.WriteString(`#include <southbridge/intel/common/gpio.h>`) adresses := [3][6]int{ @@ -309,6 +310,7 @@ sb := Create(ctx, "early_southbridge.c") defer sb.Close() AddROMStageFile("early_southbridge.c", "") + Add_gpl(sb) sb.WriteString(`#include <stdint.h> #include <string.h> #include <lib.h> @@ -407,6 +409,7 @@ gnvs := Create(ctx, "gnvs.c") defer gnvs.Close() + Add_gpl(gnvs) gnvs.WriteString(`#include <southbridge/intel/bd82x6x/nvs.h> /* FIXME: check this function. */ diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go index a0d21f1..c2dd333 100644 --- a/util/autoport/ec_lenovo.go +++ b/util/autoport/ec_lenovo.go @@ -79,25 +79,9 @@ AddSMMFile("smihandler.c", "") + Add_gpl(smi) smi.WriteString( - `/* - * This file is part of the coreboot project. - * - * Copyright (C) 2008-2009 coresystems GmbH - * Copyright (C) 2014 Vladimir Serbinenko - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of - * the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> + `#include <arch/io.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> diff --git a/util/autoport/main.go b/util/autoport/main.go index 2eb1588..1d50780 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -207,6 +207,27 @@ return mf } +func Add_gpl(fp *os.File) { + fp.WriteString(`/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +`) +} + func RestorePCI16Simple(f *os.File, pcidev PCIDevData, addr uint16) { fmt.Fprintf(f, " pci_write_config16(PCI_DEV(%d, 0x%02x, %d), 0x%02x, 0x%02x%02x);\n", pcidev.Bus, pcidev.Dev, pcidev.Func, addr, -- To view, visit https://review.coreboot.org/19510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d6b48762b1249bb0becb178a30e1396bf6978fc Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017