coreboot-gerrit January 2015

coreboot-gerrit@coreboot.org

1 participants
1236 discussions

Patch set updated for coreboot: 66c2bf5 Makefile: clang - ramp up some more warnings
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8136 -gerrit commit 66c2bf5e5704e40204d4a3dcaf08bfd988bc6696 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 6 14:58:31 2015 +1100 Makefile: clang - ramp up some more warnings Back out '-Wno-unused-function' Change-Id: I5262cba22d262f5d74d1edd958b59c2695271293 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 017ca47..51c0c58 100644 --- a/Makefile +++ b/Makefile @@ -119,7 +119,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # this means the triple is i386-linux-elf instead of i386-none-elf CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 # Tone down some clang warnings -CFLAGS_x86_32 += -Wno-unused-variable -Wno-unused-function -Wno-tautological-compare -Wno-shift-overflow +CFLAGS_x86_32 += -Wno-unused-variable -Wno-tautological-compare -Wno-shift-overflow CC_x86_32:=clang HOSTCC := clang

1 0

Patch set updated for coreboot: 29a00b1 vendorcode/amd/agesa: Remove UCODE_VS_FLAG() macro unused variable
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8200 -gerrit commit 29a00b10f78042ffc3f2afd18d668684b6dd8f21 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 05:15:25 2015 +1100 vendorcode/amd/agesa: Remove UCODE_VS_FLAG() macro unused variable Change-Id: Ia21bfc758f81e349bdd0bfd185df75e8b1898336 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- .../agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c | 5 +++-- .../f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch0600050D_Enc.c | 5 +++-- .../f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c | 5 +++-- .../agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c | 3 ++- 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c b/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c index df9c27b..6799398 100644 --- a/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c +++ b/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c @@ -64,7 +64,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (06000425) +// Unused variable +//UCODE_VS_FLAG (06000425) // Encrypted Patch code 06000425 for 6010 and equivalent CONST UINT8 ROMDATA CpuF15OrMicrocodePatch06000425 [IDS_PAD_4K] = @@ -2671,4 +2672,4 @@ CONST UINT8 ROMDATA CpuF15OrMicrocodePatch06000425 [IDS_PAD_4K] = /*---------------------------------------------------------------------------------------- * E X P O R T E D F U N C T I O N S *---------------------------------------------------------------------------------------- - */ \ No newline at end of file + */ diff --git a/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch0600050D_Enc.c b/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch0600050D_Enc.c index 5e5cf04..bb196ef 100644 --- a/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch0600050D_Enc.c +++ b/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch0600050D_Enc.c @@ -64,7 +64,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (0600050D_Enc) +// Unused variable +//UCODE_VS_FLAG (0600050D_Enc) // Encrypt Patch code 0600050D for 6011 and equivalent @@ -2672,4 +2673,4 @@ CONST UINT8 ROMDATA CpuF15OrMicrocodePatch0600050D_Enc [IDS_PAD_4K] = /*---------------------------------------------------------------------------------------- * E X P O R T E D F U N C T I O N S *---------------------------------------------------------------------------------------- - */ \ No newline at end of file + */ diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c index 311a26c..8e0ada0 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c @@ -63,7 +63,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (0600110F_Enc) +// Unused variable +//UCODE_VS_FLAG (0600110F_Enc) // Encrypt Patch code 0600110F for 6101 and equivalent @@ -2671,4 +2672,4 @@ CONST UINT8 ROMDATA CpuF15TnMicrocodePatch0600110F_Enc [IDS_PAD_4K] = /*---------------------------------------------------------------------------------------- * E X P O R T E D F U N C T I O N S *---------------------------------------------------------------------------------------- - */ \ No newline at end of file + */ diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c index 14fbfb2..be40248 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c +++ b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c @@ -63,7 +63,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (0700010B) +// Unused variable +//UCODE_VS_FLAG (0700010B) // Encrypt Patch code 0700010B for 7001 and equivalent

1 0

Patch set updated for coreboot: 9f4d3e4 Makefile: clang - ramp up some more warnings
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8197 -gerrit commit 9f4d3e407d0f5bc9b31763efe5dcaff17f030e2c Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 04:15:29 2015 +1100 Makefile: clang - ramp up some more warnings Back out '-Wno-unused-variable'. Change-Id: Icd15b03d3a41f4933c9ae0a4c497ccadcccbefb5 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 51c0c58..eda36e7 100644 --- a/Makefile +++ b/Makefile @@ -119,7 +119,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # this means the triple is i386-linux-elf instead of i386-none-elf CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 # Tone down some clang warnings -CFLAGS_x86_32 += -Wno-unused-variable -Wno-tautological-compare -Wno-shift-overflow +CFLAGS_x86_32 += -Wno-tautological-compare -Wno-shift-overflow CC_x86_32:=clang HOSTCC := clang

1 0

Patch set updated for coreboot: c110a0d northbridge/via/vx800/lpc.c: Remove unused variables
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8199 -gerrit commit c110a0d3ee76e43cbabb217b1c7e31282d2a4e79 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 05:13:49 2015 +1100 northbridge/via/vx800/lpc.c: Remove unused variables Change-Id: I1f94171173d0b3d672aebeb0dd901dd292028711 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/via/vx800/lpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/via/vx800/lpc.c b/src/northbridge/via/vx800/lpc.c index c2a8a1d..cffaeda 100644 --- a/src/northbridge/via/vx800/lpc.c +++ b/src/northbridge/via/vx800/lpc.c @@ -39,9 +39,9 @@ static const unsigned char usbdevicePins[4] = { 'A', 'B', 'C', 'D' }; //only INT static const unsigned char sdioPins[4] = { 'A', 'B', 'C', 'D' }; //only INTA static const unsigned char sd_ms_ctrl_Pins[4] = { 'B', 'C', 'D', 'A' }; //only INTA static const unsigned char ce_ata_nf_ctrl_Pins[4] = { 'C', 'C', 'D', 'A' }; //only INTA -static const unsigned char idePins[4] = { 'B', 'C', 'D', 'A' }; //only INTA +//static const unsigned char idePins[4] = { 'B', 'C', 'D', 'A' }; //only INTA -static const unsigned char usbPins[4] = { 'A', 'B', 'C', 'D' }; //all 4 +//static const unsigned char usbPins[4] = { 'A', 'B', 'C', 'D' }; //all 4 static const unsigned char hdacaudioPins[4] = { 'B', 'C', 'D', 'A' }; //only INTA

1 0

Patch set updated for coreboot: 807fb68 northbridge/intel: Avoid 'to_flash_offset()' unused func warn
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8198 -gerrit commit 807fb688924035edaee5aa2fbd68c1e4985f0b71 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 05:18:57 2015 +1100 northbridge/intel: Avoid 'to_flash_offset()' unused func warn Change-Id: I9eefc8ddf34f570626719af8e7bae569d28ea30d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/drivers/intel/fsp/fastboot_cache.c | 2 ++ src/northbridge/intel/haswell/mrccache.c | 2 ++ src/northbridge/intel/sandybridge/mrccache.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/drivers/intel/fsp/fastboot_cache.c b/src/drivers/intel/fsp/fastboot_cache.c index 64982d8..674c4bc 100644 --- a/src/drivers/intel/fsp/fastboot_cache.c +++ b/src/drivers/intel/fsp/fastboot_cache.c @@ -35,10 +35,12 @@ #error "CONFIG_VIRTUAL_ROM_SIZE must be set." #endif +#if !defined(__PRE_RAM__) /* convert a pointer to flash area into the offset inside the flash */ static inline u32 to_flash_offset(void *p) { return ((u32)p + CONFIG_VIRTUAL_ROM_SIZE); } +#endif /* !defined(__PRE_RAM__) */ static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache) diff --git a/src/northbridge/intel/haswell/mrccache.c b/src/northbridge/intel/haswell/mrccache.c index 540bbf6..88e7854 100644 --- a/src/northbridge/intel/haswell/mrccache.c +++ b/src/northbridge/intel/haswell/mrccache.c @@ -33,10 +33,12 @@ #include <vendorcode/google/chromeos/fmap.h> #endif +#if !defined(__PRE_RAM__) /* convert a pointer to flash area into the offset inside the flash */ static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { return ((u32)p + flash->size); } +#endif /* !defined(__PRE_RAM__) */ static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache) diff --git a/src/northbridge/intel/sandybridge/mrccache.c b/src/northbridge/intel/sandybridge/mrccache.c index c84ff82..4472cd0 100644 --- a/src/northbridge/intel/sandybridge/mrccache.c +++ b/src/northbridge/intel/sandybridge/mrccache.c @@ -33,10 +33,12 @@ #include <vendorcode/google/chromeos/fmap.h> #endif +#if !defined(__PRE_RAM__) /* convert a pointer to flash area into the offset inside the flash */ static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { return ((u32)p + flash->size); } +#endif /* !defined(__PRE_RAM__) */ static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache)

1 0

Patch merged into coreboot/master: 97ccefd southbridge/intel/lynxpoint/me_9.x.c: Avoid unused func warn
by gerrit＠coreboot.org 12 Jan '15

12 Jan '15

the following patch was just integrated into master: commit 97ccefdaf34ea2f4e2527d98465cb3b96fcf436d Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Wed Jan 7 15:53:00 2015 +1100 southbridge/intel/lynxpoint/me_9.x.c: Avoid unused func warn Put functions in appropriate pre-processor sections to avoid false-positive 'unused function' compiler warnings. Change-Id: Ie4955ee9df6904c38848f46226b53be37d9fa239 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/8157 Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/8157 for details. -gerrit

1 0

Patch set updated for coreboot: 4c4c9d7 southbridge/intel/lynxpoint/me_9.x.c: Avoid unused func warn
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8157 -gerrit commit 4c4c9d742ccccead543dcfe94bffa4ef9c9ea5b6 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Wed Jan 7 15:53:00 2015 +1100 southbridge/intel/lynxpoint/me_9.x.c: Avoid unused func warn Put functions in appropriate pre-processor sections to avoid false-positive 'unused function' compiler warnings. Change-Id: Ie4955ee9df6904c38848f46226b53be37d9fa239 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/southbridge/intel/lynxpoint/me_9.x.c | 50 +++++++++++++++++--------------- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/src/southbridge/intel/lynxpoint/me_9.x.c b/src/southbridge/intel/lynxpoint/me_9.x.c index dfed6de..9670bbb 100644 --- a/src/southbridge/intel/lynxpoint/me_9.x.c +++ b/src/southbridge/intel/lynxpoint/me_9.x.c @@ -374,6 +374,7 @@ static int mei_recv_msg(void *header, int header_bytes, return mei_wait_for_me_ready(); } +#if IS_ENABLED (CONFIG_DEBUG_INTEL_ME) || defined(__SMM__) static inline int mei_sendrecv_mkhi(struct mkhi_header *mkhi, void *req_data, int req_bytes, void *rsp_data, int rsp_bytes) @@ -411,30 +412,7 @@ static inline int mei_sendrecv_mkhi(struct mkhi_header *mkhi, return 0; } - -static inline int mei_sendrecv_icc(struct icc_header *icc, - void *req_data, int req_bytes, - void *rsp_data, int rsp_bytes) -{ - struct icc_header icc_rsp; - - /* Send header */ - if (mei_send_header(MEI_ADDRESS_ICC, MEI_HOST_ADDRESS, - icc, sizeof(*icc), req_bytes ? 0 : 1) < 0) - return -1; - - /* Send data if available */ - if (req_bytes && mei_send_data(MEI_ADDRESS_ICC, MEI_HOST_ADDRESS, - req_data, req_bytes) < 0) - return -1; - - /* Read header and data, if needed */ - if (rsp_bytes && mei_recv_msg(&icc_rsp, sizeof(icc_rsp), - rsp_data, rsp_bytes) < 0) - return -1; - - return 0; -} +#endif /* CONFIG_DEBUG_INTEL_ME || __SMM__ */ /* * mbp give up routine. This path is taken if hfs.mpb_rdy is 0 or the read @@ -636,6 +614,30 @@ void intel_me_finalize_smm(void) #else /* !__SMM__ */ +static inline int mei_sendrecv_icc(struct icc_header *icc, + void *req_data, int req_bytes, + void *rsp_data, int rsp_bytes) +{ + struct icc_header icc_rsp; + + /* Send header */ + if (mei_send_header(MEI_ADDRESS_ICC, MEI_HOST_ADDRESS, + icc, sizeof(*icc), req_bytes ? 0 : 1) < 0) + return -1; + + /* Send data if available */ + if (req_bytes && mei_send_data(MEI_ADDRESS_ICC, MEI_HOST_ADDRESS, + req_data, req_bytes) < 0) + return -1; + + /* Read header and data, if needed */ + if (rsp_bytes && mei_recv_msg(&icc_rsp, sizeof(icc_rsp), + rsp_data, rsp_bytes) < 0) + return -1; + + return 0; +} + static int me_icc_set_clock_enables(u32 mask) { struct icc_clock_enables_msg clk = {

1 0

New patch to review for coreboot: 77b8a78 vendorcode/amd/agesa: Remove UCODE_VS_FLAG() macro unused variable
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8200 -gerrit commit 77b8a7810c21c95212ceba50ee464e7c69cf90ee Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 05:15:25 2015 +1100 vendorcode/amd/agesa: Remove UCODE_VS_FLAG() macro unused variable Change-Id: Ia21bfc758f81e349bdd0bfd185df75e8b1898336 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- .../agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c | 5 +++-- .../f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c | 5 +++-- .../agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c b/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c index df9c27b..6799398 100644 --- a/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c +++ b/src/vendorcode/amd/agesa/f15/Proc/CPU/Family/0x15/OR/F15OrMicrocodePatch06000425.c @@ -64,7 +64,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (06000425) +// Unused variable +//UCODE_VS_FLAG (06000425) // Encrypted Patch code 06000425 for 6010 and equivalent CONST UINT8 ROMDATA CpuF15OrMicrocodePatch06000425 [IDS_PAD_4K] = @@ -2671,4 +2672,4 @@ CONST UINT8 ROMDATA CpuF15OrMicrocodePatch06000425 [IDS_PAD_4K] = /*---------------------------------------------------------------------------------------- * E X P O R T E D F U N C T I O N S *---------------------------------------------------------------------------------------- - */ \ No newline at end of file + */ diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c index 311a26c..8e0ada0 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMicrocodePatch0600110F_Enc.c @@ -63,7 +63,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (0600110F_Enc) +// Unused variable +//UCODE_VS_FLAG (0600110F_Enc) // Encrypt Patch code 0600110F for 6101 and equivalent @@ -2671,4 +2672,4 @@ CONST UINT8 ROMDATA CpuF15TnMicrocodePatch0600110F_Enc [IDS_PAD_4K] = /*---------------------------------------------------------------------------------------- * E X P O R T E D F U N C T I O N S *---------------------------------------------------------------------------------------- - */ \ No newline at end of file + */ diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c index 14fbfb2..be40248 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c +++ b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbId7001MicrocodePatch.c @@ -63,7 +63,8 @@ RDATA_GROUP (G3_DXE) *---------------------------------------------------------------------------------------- */ -UCODE_VS_FLAG (0700010B) +// Unused variable +//UCODE_VS_FLAG (0700010B) // Encrypt Patch code 0700010B for 7001 and equivalent

1 0

New patch to review for coreboot: c46be68 northbridge/via/vx800/lpc.c: Remove unused variables
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8199 -gerrit commit c46be689039ff77337336025f621c7e857f5f705 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 05:13:49 2015 +1100 northbridge/via/vx800/lpc.c: Remove unused variables Change-Id: I1f94171173d0b3d672aebeb0dd901dd292028711 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/via/vx800/lpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/via/vx800/lpc.c b/src/northbridge/via/vx800/lpc.c index c2a8a1d..cffaeda 100644 --- a/src/northbridge/via/vx800/lpc.c +++ b/src/northbridge/via/vx800/lpc.c @@ -39,9 +39,9 @@ static const unsigned char usbdevicePins[4] = { 'A', 'B', 'C', 'D' }; //only INT static const unsigned char sdioPins[4] = { 'A', 'B', 'C', 'D' }; //only INTA static const unsigned char sd_ms_ctrl_Pins[4] = { 'B', 'C', 'D', 'A' }; //only INTA static const unsigned char ce_ata_nf_ctrl_Pins[4] = { 'C', 'C', 'D', 'A' }; //only INTA -static const unsigned char idePins[4] = { 'B', 'C', 'D', 'A' }; //only INTA +//static const unsigned char idePins[4] = { 'B', 'C', 'D', 'A' }; //only INTA -static const unsigned char usbPins[4] = { 'A', 'B', 'C', 'D' }; //all 4 +//static const unsigned char usbPins[4] = { 'A', 'B', 'C', 'D' }; //all 4 static const unsigned char hdacaudioPins[4] = { 'B', 'C', 'D', 'A' }; //only INTA

1 0

New patch to review for coreboot: e5ff30a northbridge/intel: Avoid 'to_flash_offset()' unused func warn
by Edward O'Callaghan 12 Jan '15

12 Jan '15

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8198 -gerrit commit e5ff30a36455027091cef93a92657dbc2a20625e Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jan 13 05:18:57 2015 +1100 northbridge/intel: Avoid 'to_flash_offset()' unused func warn Change-Id: I9eefc8ddf34f570626719af8e7bae569d28ea30d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/intel/haswell/mrccache.c | 2 ++ src/northbridge/intel/sandybridge/mrccache.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/northbridge/intel/haswell/mrccache.c b/src/northbridge/intel/haswell/mrccache.c index 540bbf6..88e7854 100644 --- a/src/northbridge/intel/haswell/mrccache.c +++ b/src/northbridge/intel/haswell/mrccache.c @@ -33,10 +33,12 @@ #include <vendorcode/google/chromeos/fmap.h> #endif +#if !defined(__PRE_RAM__) /* convert a pointer to flash area into the offset inside the flash */ static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { return ((u32)p + flash->size); } +#endif /* !defined(__PRE_RAM__) */ static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache) diff --git a/src/northbridge/intel/sandybridge/mrccache.c b/src/northbridge/intel/sandybridge/mrccache.c index c84ff82..4472cd0 100644 --- a/src/northbridge/intel/sandybridge/mrccache.c +++ b/src/northbridge/intel/sandybridge/mrccache.c @@ -33,10 +33,12 @@ #include <vendorcode/google/chromeos/fmap.h> #endif +#if !defined(__PRE_RAM__) /* convert a pointer to flash area into the offset inside the flash */ static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { return ((u32)p + flash->size); } +#endif /* !defined(__PRE_RAM__) */ static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache)

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2015