coreboot-gerrit August 2014

coreboot-gerrit@coreboot.org

1 participants
1011 discussions

Patch set updated for coreboot: 938d2a7 lenovo/t520: Fix ExpressCard hotplug
by Nicolas Reinecke 22 Aug '14

22 Aug '14

Nicolas Reinecke (nr(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6735 -gerrit commit 938d2a736b6cbc7ecbe55794ffa35cccc5636370 Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Fri Aug 22 15:10:49 2014 +0200 lenovo/t520: Fix ExpressCard hotplug Thinkpad T520 ExpressCard Slot PCIe lanes are connected to port 4. Tested with Serial Port Card. Change-Id: I459943d427578d135f9aed1aa66da269ddfeee87 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> --- src/mainboard/lenovo/t520/dsdt.asl | 2 +- src/mainboard/lenovo/t520/mainboard.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mainboard/lenovo/t520/dsdt.asl b/src/mainboard/lenovo/t520/dsdt.asl index 0e7a965..e48a590 100644 --- a/src/mainboard/lenovo/t520/dsdt.asl +++ b/src/mainboard/lenovo/t520/dsdt.asl @@ -23,7 +23,7 @@ #define BRIGHTNESS_UP \_SB.PCI0.GFX0.LCD0.INCB #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.LCD0.DECB #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 -#define RP03_IS_EXPRESSCARD 1 +#define RP04_IS_EXPRESSCARD 1 #define HAVE_LCD_SCREEN 1 DefinitionBlock( diff --git a/src/mainboard/lenovo/t520/mainboard.c b/src/mainboard/lenovo/t520/mainboard.c index c37e6b9..8b1aa0d 100644 --- a/src/mainboard/lenovo/t520/mainboard.c +++ b/src/mainboard/lenovo/t520/mainboard.c @@ -158,12 +158,11 @@ static void mainboard_init(device_t dev) pc_keyboard_init(); /* Enable expresscard hotplug events. */ - pci_write_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), + pci_write_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0xd8, - pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), 0xd8) + pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0xd8) | (1 << 30)); - - pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), + pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0x42, 0x142); }

1 0

Patch set updated for coreboot: 0c35f3a lenovo/t520: Fix ExpressCard hotplug
by Nicolas Reinecke 22 Aug '14

22 Aug '14

Nicolas Reinecke (nr(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6735 -gerrit commit 0c35f3a49660614fe902c24f1b6aea81ba5119ab Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Fri Aug 22 15:10:49 2014 +0200 lenovo/t520: Fix ExpressCard hotplug Thinkpad T520 Expresscard Slot PCIe lanes are connected to port 4 Change-Id: I459943d427578d135f9aed1aa66da269ddfeee87 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> --- src/mainboard/lenovo/t520/dsdt.asl | 2 +- src/mainboard/lenovo/t520/mainboard.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mainboard/lenovo/t520/dsdt.asl b/src/mainboard/lenovo/t520/dsdt.asl index 0e7a965..e48a590 100644 --- a/src/mainboard/lenovo/t520/dsdt.asl +++ b/src/mainboard/lenovo/t520/dsdt.asl @@ -23,7 +23,7 @@ #define BRIGHTNESS_UP \_SB.PCI0.GFX0.LCD0.INCB #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.LCD0.DECB #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 -#define RP03_IS_EXPRESSCARD 1 +#define RP04_IS_EXPRESSCARD 1 #define HAVE_LCD_SCREEN 1 DefinitionBlock( diff --git a/src/mainboard/lenovo/t520/mainboard.c b/src/mainboard/lenovo/t520/mainboard.c index c37e6b9..8b1aa0d 100644 --- a/src/mainboard/lenovo/t520/mainboard.c +++ b/src/mainboard/lenovo/t520/mainboard.c @@ -158,12 +158,11 @@ static void mainboard_init(device_t dev) pc_keyboard_init(); /* Enable expresscard hotplug events. */ - pci_write_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), + pci_write_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0xd8, - pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), 0xd8) + pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0xd8) | (1 << 30)); - - pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), + pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0x42, 0x142); }

1 0

New patch to review for coreboot: 2e45488 lenovo/t520: Remove empty smi.h
by Nicolas Reinecke 22 Aug '14

22 Aug '14

Nicolas Reinecke (nr(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6736 -gerrit commit 2e454888d3ef00fef3d91d399c3a3bcce0e9ffa5 Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Fri Aug 22 15:22:20 2014 +0200 lenovo/t520: Remove empty smi.h Change-Id: I60fa19b72f91f16db5f354aeec631f661e3494d3 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> --- src/mainboard/lenovo/t520/smi.h | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/src/mainboard/lenovo/t520/smi.h b/src/mainboard/lenovo/t520/smi.h deleted file mode 100644 index f7ffb41..0000000 --- a/src/mainboard/lenovo/t520/smi.h +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2010 coresystems GmbH - * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. - * Copyright (C) 2014 Vladimir Serbinenko - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ \ No newline at end of file

1 0

New patch to review for coreboot: 1ca04e3 lenovo/t520: Fix Expresscard hotplug
by Nicolas Reinecke 22 Aug '14

22 Aug '14

Nicolas Reinecke (nr(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6735 -gerrit commit 1ca04e38f36b2c237f4d4c443826cca8db135d28 Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Fri Aug 22 15:10:49 2014 +0200 lenovo/t520: Fix Expresscard hotplug Thinkpad T520 Expresscard Slot PCIe lanes are connected to port 4 Change-Id: I459943d427578d135f9aed1aa66da269ddfeee87 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> --- src/mainboard/lenovo/t520/dsdt.asl | 2 +- src/mainboard/lenovo/t520/mainboard.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mainboard/lenovo/t520/dsdt.asl b/src/mainboard/lenovo/t520/dsdt.asl index 0e7a965..e48a590 100644 --- a/src/mainboard/lenovo/t520/dsdt.asl +++ b/src/mainboard/lenovo/t520/dsdt.asl @@ -23,7 +23,7 @@ #define BRIGHTNESS_UP \_SB.PCI0.GFX0.LCD0.INCB #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.LCD0.DECB #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 -#define RP03_IS_EXPRESSCARD 1 +#define RP04_IS_EXPRESSCARD 1 #define HAVE_LCD_SCREEN 1 DefinitionBlock( diff --git a/src/mainboard/lenovo/t520/mainboard.c b/src/mainboard/lenovo/t520/mainboard.c index c37e6b9..8b1aa0d 100644 --- a/src/mainboard/lenovo/t520/mainboard.c +++ b/src/mainboard/lenovo/t520/mainboard.c @@ -158,12 +158,11 @@ static void mainboard_init(device_t dev) pc_keyboard_init(); /* Enable expresscard hotplug events. */ - pci_write_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), + pci_write_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0xd8, - pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), 0xd8) + pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0xd8) | (1 << 30)); - - pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x1c, 2)), + pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x1c, 3)), 0x42, 0x142); }

1 0

Patch merged into coreboot/master: 0754227 lenovo/{x230, t530}: Remove empty smi.h
by gerrit＠coreboot.org 22 Aug '14

22 Aug '14

the following patch was just integrated into master: commit 075422704437b893849f0a39d86130227e75f913 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Thu Aug 21 21:15:54 2014 +0200 lenovo/{x230,t530}: Remove empty smi.h Change-Id: I26fa6508f50faff7f1c1724884b5ffa30463b896 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6728 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/6728 for details. -gerrit

1 0

Patch merged into coreboot/master: bcf58a4 lenovo/x230: Remove empty mainboard.asl
by gerrit＠coreboot.org 22 Aug '14

22 Aug '14

the following patch was just integrated into master: commit bcf58a44d19a213069ac404b15be792ac58e0c15 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Thu Aug 21 21:14:31 2014 +0200 lenovo/x230: Remove empty mainboard.asl Change-Id: Ic877d6285ce3983268b16ddb5b4e15743f5adf86 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6727 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/6727 for details. -gerrit

1 0

Patch merged into coreboot/master: caf1d2c lenovo/x200: Remove empty mainboard.asl
by gerrit＠coreboot.org 22 Aug '14

22 Aug '14

the following patch was just integrated into master: commit caf1d2c0f1353d5a52f45638fd058a5211892e23 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Thu Aug 21 21:13:46 2014 +0200 lenovo/x200: Remove empty mainboard.asl Change-Id: I560d693d0d72ca8dcd099eff6b0c40716fb0c0b0 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6726 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/6726 for details. -gerrit

1 0

Patch merged into coreboot/master: bb1699e lenovo/x200: Move video ASL code to northbridge.
by gerrit＠coreboot.org 22 Aug '14

22 Aug '14

the following patch was just integrated into master: commit bb1699ecbc867ebe3c592384bdb5233db9281695 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Thu Aug 21 22:19:48 2014 +0200 lenovo/x200: Move video ASL code to northbridge. Change-Id: I58760500252e78da947685c18201b6d446368333 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6729 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6729 for details. -gerrit

1 0

Patch merged into coreboot/master: f3c472f lenovo/x201: Remove empty mainboard.asl
by gerrit＠coreboot.org 22 Aug '14

22 Aug '14

the following patch was just integrated into master: commit f3c472feedf416b8c9576536fe391ab62ab5263f Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Thu Aug 21 20:20:27 2014 +0200 lenovo/x201: Remove empty mainboard.asl Change-Id: I37d48279b1b022c4573bd09d3db6bf536d5dab9a Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6724 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/6724 for details. -gerrit

1 0

Patch merged into coreboot/master: af906fd apple/macbook21: Remove useless seabios config
by gerrit＠coreboot.org 22 Aug '14

22 Aug '14

the following patch was just integrated into master: commit af906fd0646f275c66e981a3f162a494ff7e2314 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Fri Aug 22 03:08:41 2014 +0200 apple/macbook21: Remove useless seabios config Change-Id: If771a84f25710e1fb2228816e3ca0139e2f95aa7 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6732 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6732 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2014